From owner-svn-src-all@freebsd.org Wed Sep 18 08:37:31 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 14A45F7777 for ; Wed, 18 Sep 2019 08:37:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YCyy1t3Mz43j7 for ; Wed, 18 Sep 2019 08:37:30 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id y144so7157220qkb.7 for ; Wed, 18 Sep 2019 01:37:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6FYq9RJi/7MgmXDJn8UxswwKOI0zTBhKb78CwHGTUck=; b=o9xUD/YZRQjI/fopRmb3s4TJT7p30L8xmRYd+sc3T2O5qEskKZoWvmL+YtDWfeEQMx Wzgu6c686/OZ0SnI9r8ve/YTPpUOXiQMHFnHoPLomPvcEURf30ceNhzHzpDwHhNuhy7L Jt/AyksfL4FJteqjxx5m+wODB/k6GMhNtUyyXirK62LEgl3+kZDBS6vcM4+ghMcaIwcI DpxNY2khaylU5ESY4wJsYn3u/6VbFHSdNCqcuzk58Kq7JsAv2PDpolnYZRMQhyQUfey0 J0fDSrFzRIjmVnfRPB01ZirW6/+bR0fh4Ud7Kvzpj2YMYB8b4RuEho3RhSP6qnMdmwEr 5Uow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6FYq9RJi/7MgmXDJn8UxswwKOI0zTBhKb78CwHGTUck=; b=cBXxfEqVApMTzvbBhhLg0wQ4crPyiYI5LWmV+/16crnse74JluQwNXWM0T0XkFkVh8 1eM8kFgyYX31i06OCK7vshhWSxkJW5cLZjssvlWV5CgVGSidttUhG0EAyFfBUaPl/KF+ R8GZNe8XLJKazo/H5jepCCx/z6wAC3ICfFjVJ6CFGXFbsCX27aL2IF9OTYrqBBQY+js3 5unxOoW2ISeE94W2xkM0HKukQ+z/4usrvMuk2ZZk/OZZyzeCNZiaMEDz3XBj+vYdIJfq smKaTGn0wqzruPMZlLxpVSU9u/WlXm48Qcl//oUua0jvTqu/bbS3YMMGJOfJZQfdPjYA qEkg== X-Gm-Message-State: APjAAAVcSiCRWcMbpdiacUrN8ZCrb7hYgmSEbolEIBf5y1NlvA7yWhbf QkHeTEuOct1OC/lHpuirOcb93/A38vwIEoakJP7oXA== X-Google-Smtp-Source: APXvYqwYSHKVKaryplEKnx3iTb6hPz102prEOk5j7hRIhLlPuO2pMYjCParu9FijQcXpvak6B4Sei4/5O2tufS/XAZ0= X-Received: by 2002:a37:30f:: with SMTP id 15mr2537199qkd.240.1568795849315; Wed, 18 Sep 2019 01:37:29 -0700 (PDT) MIME-Version: 1.0 References: <201909171616.x8HGGlkb066218@repo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 18 Sep 2019 09:37:17 +0100 Message-ID: Subject: Re: svn commit: r352451 - head/stand/libsa To: "Conrad E. Meyer" Cc: Toomas Soome , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46YCyy1t3Mz43j7 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=o9xUD/YZ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::729) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.85)[ip: (-9.29), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 08:37:31 -0000 On Wed, Sep 18, 2019, 12:18 AM Conrad Meyer wrote: > Well, hang on; it's also perfectly legal for a malloc implementation > to return NULL for requests of zero bytes. You can access exactly the > number of bytes requested in the allocation; and free(NULL) works as > expected. NULL (0) is also aligned to any size you could want. > Legal, yes. But it is different than all the other FreeBSD environments, so the loader becomes the odd man out. This restores the consistency. Warner Best, > Conrad > > On Tue, Sep 17, 2019 at 9:16 AM Toomas Soome wrote: > > > > Author: tsoome > > Date: Tue Sep 17 16:16:46 2019 > > New Revision: 352451 > > URL: https://svnweb.freebsd.org/changeset/base/352451 > > > > Log: > > loader: revert r352421 > > > > As insisted by kib, malloc(0) is quite legal. > > > > Modified: > > head/stand/libsa/zalloc_malloc.c > > > > Modified: head/stand/libsa/zalloc_malloc.c > > > ============================================================================== > > --- head/stand/libsa/zalloc_malloc.c Tue Sep 17 15:53:40 2019 > (r352450) > > +++ head/stand/libsa/zalloc_malloc.c Tue Sep 17 16:16:46 2019 > (r352451) > > @@ -73,9 +73,6 @@ Malloc_align(size_t bytes, size_t alignment) > > { > > Guard *res; > > > > - if (bytes == 0) > > - return (NULL); > > - > > #ifdef USEENDGUARD > > bytes += MALLOCALIGN + 1; > > #else >