From owner-svn-src-projects@freebsd.org Wed Feb 13 14:42:41 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55C4B14F1566 for ; Wed, 13 Feb 2019 14:42:41 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C24E88CFA5; Wed, 13 Feb 2019 14:42:40 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1DEgcGw081704; Wed, 13 Feb 2019 06:42:38 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1DEgcsa081703; Wed, 13 Feb 2019 06:42:38 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902131442.x1DEgcsa081703@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344087 - in projects/import-googletest-1.8.1/lib/googletest: gmock/tests gtest/tests In-Reply-To: To: Enji Cooper Date: Wed, 13 Feb 2019 06:42:38 -0800 (PST) CC: rgrimes@freebsd.org, Enji Cooper , src-committers@freebsd.org, svn-src-projects@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C24E88CFA5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.95)[-0.947,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 14:42:41 -0000 > On Feb 13, 2019, at 06:26, Rodney W. Grimes wrote: > > >> Author: ngie > >> Date: Wed Feb 13 05:41:04 2019 > >> New Revision: 344087 > >> URL: https://svnweb.freebsd.org/changeset/base/344087 > >> > >> Log: > >> Compile the tests without -Werror for now > >> > >> I'm working on resolving the issue upstream on github > >> > >> Modified: > >> projects/import-googletest-1.8.1/lib/googletest/gmock/tests/Makefile > >> projects/import-googletest-1.8.1/lib/googletest/gtest/tests/Makefile > > > > Are we going to have to live with this project name of > > import-googletest-1.8.1 long term, or is this just a > > stepping stone? > > It?s a short lived project. I didn?t realize in the last year and a > half that branch names had formalized into something else, especially > since GUIDELINES.txt doesn?t state a naming convention. I do not know that they have formalized in any way. But as long as it is shorted lived it really does not matter much. Please do be careful when choosing a vendor/ directory name if that is where this is headed, 'import' and '1.8.1' are probably not wanted there at all, just googletest. > I could move the project to another name, > but that seems like a waste of a commit > and like it would make it more difficult to track the project history. I Agree. > -Enji -- Rod Grimes rgrimes@freebsd.org