From owner-svn-src-head@FreeBSD.ORG Thu Jan 15 18:51:53 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 534526DC; Thu, 15 Jan 2015 18:51:53 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 282F3EDC; Thu, 15 Jan 2015 18:51:53 +0000 (UTC) Received: from new-host-2.home (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2E09AB91F; Thu, 15 Jan 2015 13:51:51 -0500 (EST) Message-ID: <54B80C46.2010409@FreeBSD.org> Date: Thu, 15 Jan 2015 13:51:50 -0500 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Nathan Whitehorn , Warner Losh , Justin Hibbits Subject: Re: svn commit: r277163 - head/sys/dev/cardbus References: <201501140541.t0E5fV00070032@svn.freebsd.org> <54B67BC9.70904@FreeBSD.org> <20150114073246.74c159df@zhabar.attlocal.net> <8CB7CB29-FBFF-4850-A226-4FA5B6BF6A87@bsdimp.com> <54B7E8EA.1090509@freebsd.org> In-Reply-To: <54B7E8EA.1090509@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 15 Jan 2015 13:51:51 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jan 2015 18:51:53 -0000 On 1/15/15 11:20 AM, Nathan Whitehorn wrote: > > On 01/14/15 16:07, Warner Losh wrote: >>> On Jan 14, 2015, at 8:32 AM, Justin Hibbits >>> wrote: >>> >>> On Wed, 14 Jan 2015 09:23:05 -0500 >>> John Baldwin wrote: >>> >>>> On 1/14/15 12:41 AM, Warner Losh wrote: >>>>> Author: imp >>>>> Date: Wed Jan 14 05:41:31 2015 >>>>> New Revision: 277163 >>>>> URL: https://svnweb.freebsd.org/changeset/base/277163 >>>>> >>>>> Log: >>>>> Add a rather obnoxious warning if you don't have NEW_PCIB defined >>>>> since it's a total crap shoot if things will work. >>>> Should we just make it a #error instead? (Some day I hope to have >>>> NEW_PCIB enabled by default and remove the old code. Will take a >>>> while to get there for the generic PCI code, but cardbus is probably >>>> only used on x86 so that would be fine.) >>>> >>> Also powerpc, but NEW_PCIB is default there as well. >> PowerPC doesn’t seem to defined the bus number resources. >> >> Warner >> > > Which ones? > -Nathan PCI_RES_BUS. https://svnweb.freebsd.org/base?view=revision&revision=261790 I misspoke about it being in the nexus. On x86 it is done in the ACPI Host-PCI bridge drivers (since those have a _SEG method to know which PCI domain/segment/hose the child bus belongs to). You could conceivably do it higher up at whatever level understands which PCI domain a given Host-PCI bridge lives in. If you only ever support a single PCI domain, you could just place it in the nexus with a hardcoded domain arg of 0 to the pci_domain_*() functions. -- John Baldwin