From owner-svn-src-head@freebsd.org Wed Feb 27 01:03:57 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDA98150A93C; Wed, 27 Feb 2019 01:03:56 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 54D7884B72; Wed, 27 Feb 2019 01:03:56 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1R13sdQ048477; Tue, 26 Feb 2019 17:03:54 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1R13rQg048476; Tue, 26 Feb 2019 17:03:53 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902270103.x1R13rQg048476@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344487 - in head/sys: conf gnu/gcov In-Reply-To: <20190227004919.GJ47081@spindle.one-eyed-alien.net> To: Brooks Davis Date: Tue, 26 Feb 2019 17:03:53 -0800 (PST) CC: "K. Macy" , Matt Macy , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 54D7884B72 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.92)[-0.920,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 01:03:57 -0000 > On Tue, Feb 26, 2019 at 05:52:48PM +0000, Brooks Davis wrote: > > On Mon, Feb 25, 2019 at 05:11:26PM -0800, K. Macy wrote: > > > > An additional issue is that the a warning tag was not added to > > > > sys/conf/files. A warning along the lines of: > > > > > > > > warning "kernel contains GPLv2 licensed GCOV" > > > > > > > > needs to be added. > > > > > > Yup. > > > > > > > > > > > This commit needed more through review. > > > > > > How would this be achieved:? I had several people on the review and no > > > one had substantive feedback. > > > > For GPL stuff, add #core to the reviewers list and feel free to drop us > > an email to make sure we see it promptly. > > FYI, we've had phab-admin@ add a herald rule to add #core as a reviewer > automatically for changes that add new lines containing either the SPDX > tag or the string "GNU General Public License". Hopefully this will > limit future drama in this area. Documentation updates are in also in > progress. Thank you! Now can you get phab-admin to respond to my 3 emails, and jhb@'s at least one email on the topic of the #bhyve phab rules that I carry in my personal login. I have made multiple requests to have this handled, with not even a ank from phab-admin. I ask for the 3rd time, is there plans to update the text in the commiters guide to reflect the text of the /internal/ policy document? > -- brooks Thanks again, -- Rod Grimes rgrimes@freebsd.org