From owner-cvs-all Mon May 7 8:40: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id D30F237B424; Mon, 7 May 2001 08:39:50 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f47FdlG34924; Mon, 7 May 2001 08:39:47 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200105071113.f47BDDN96189@freefall.freebsd.org> Date: Mon, 07 May 2001 08:35:27 -0700 (PDT) From: John Baldwin To: Brian Somers Subject: RE: cvs commit: src/sys/dev/digi digi.c digi.h digi_isa.c digi_p Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 07-May-01 Brian Somers wrote: > brian 2001/05/07 04:13:13 PDT > > Modified files: > sys/dev/digi digi.c digi.h digi_isa.c digi_pci.c > Log: > Change COM_LOCK/COM_UNLOCK to a regular mutex - still conditional on > SMP being defined. Woah. COM_LOCK is a special case due to sio/cy using fast interrupt handlers, and if digi is using a fast interrupt handler, then it needs to be a spin mutex, not a regular mutex. Also, mutexes should be on all the time, not just #ifdef SMP. Note that COM_LOCK is always defined now. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message