From owner-freebsd-ports@FreeBSD.ORG Mon Aug 20 15:54:28 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 726AD1065689; Mon, 20 Aug 2012 15:54:28 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id AB6598FC15; Mon, 20 Aug 2012 15:54:27 +0000 (UTC) Received: by vcbgb22 with SMTP id gb22so6603690vcb.13 for ; Mon, 20 Aug 2012 08:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=P2Ix3XU8A4Ip2mkQA2gEqvwwP6+J+E2gbliWuO/i/js=; b=BLdRQfU6n+4krRyqeLgk5CRni4OpDjqBtYVU1Iztk8ArgzTrXGKRy9N/+oqn8h9FTV ET2lk/35Xo2cxsQ9sJBBeO7za6dxGQ0vxlmPUkOo793DXxRkJQAH5efDHO3ML/eHujkM zzEjOB6hp5MS3rezkZHfLGC8Ms2oSpA1zoJ4MjXuYJySu/Ct4WTZiuxjPR+8PHAxRug+ ANvRK0ts2jVhtSmbVfSkJ9ppKa1eqG7kxO24exEQnYW5BlE5iMwx4HAbWb6D72V9fHz0 uEnmE9juX7at7+wQwcUgofL0ImyU+mecLDkGLjZwrsHycJe1Bu9j0637eJ5xNenewuli MedQ== Received: by 10.220.108.15 with SMTP id d15mr10705585vcp.37.1345478067072; Mon, 20 Aug 2012 08:54:27 -0700 (PDT) Received: from kan.dyndns.org (c-24-63-226-98.hsd1.ma.comcast.net. [24.63.226.98]) by mx.google.com with ESMTPS id bm15sm5457601vdb.22.2012.08.20.08.54.25 (version=SSLv3 cipher=OTHER); Mon, 20 Aug 2012 08:54:25 -0700 (PDT) Date: Mon, 20 Aug 2012 11:54:11 -0400 From: Alexander Kabaev To: Konstantin Belousov Message-ID: <20120820115411.4134af08@kan.dyndns.org> In-Reply-To: <20120820101510.GJ33100@deviant.kiev.zoral.com.ua> References: <20120813211109.GA71682@triton8.kn-bremen.de> <20120813214651.GA72570@triton8.kn-bremen.de> <5029D6AE.4050205@gwdg.de> <20120814114214.GB94259@triton8.kn-bremen.de> <502A8206.4090505@gwdg.de> <20120814192453.GA8026@triton8.kn-bremen.de> <502AAD0E.2070909@FreeBSD.org> <20120815120143.GB33206@triton8.kn-bremen.de> <20120818204510.GA70765@triton8.kn-bremen.de> <20120820101510.GJ33100@deviant.kiev.zoral.com.ua> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.6; amd64-portbld-freebsd10.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/CaBsWPFxGA19IQqehbrwp+F"; protocol="application/pgp-signature" Cc: freebsd-multimedia@freebsd.org, kan@freebsd.org, Juergen Lock , Kevin Oberman , FreeBSD Ports , freebsd-ports@freebsd.org Subject: Re: __FreeBSD_version bump? (was: Re: vlc 2.0.3 ProjectM path fix) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 15:54:28 -0000 --Sig_/CaBsWPFxGA19IQqehbrwp+F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 20 Aug 2012 13:15:10 +0300 Konstantin Belousov wrote: > On Sat, Aug 18, 2012 at 10:45:10PM +0200, Juergen Lock wrote: > > On Wed, Aug 15, 2012 at 10:09:59AM -0700, Kevin Oberman wrote: > > > On Wed, Aug 15, 2012 at 5:01 AM, Juergen Lock > > > wrote: > > > > On Tue, Aug 14, 2012 at 09:54:54PM +0200, Olli Hauer wrote: > > > >> ... > > > >> >> I think I got it: It is only a problem of configuring in > > > >> >> the running vlc. You have to set the right path under > > > >> >> 'Settings','All','Audio','Visualizing','projectM'. That's > > > >> >> all ;-) > > > >> >> > > > >> > Aah-haah! :) I've fixed the default paths and made a new > > > >> > patch: > > > >> > > > > >> > http://people.freebsd.org/~nox/tmp/vlc-2.0.3-010.patch > > > >> > > > > >> > > > >> > > > >> >From your patch: > > > >> > workaround is to deinstall the old vlc-1.x version before > > > >> > building the new one. > > > >> > > > >> What about a conflict line ? > > > >> CONFLICTS_BUILD=3D${PORTNAME}-1.* > > > >> > > > >> This allows users to fetch the source but they have to > > > >> deinstall the old version before building the new one. > > > > > > > > Hm well the rtld bug this workaround is for only affects the > > > > pulseaudio and notify knobs, and the workaround doesn't work for > > > > the notify knob so it would only cover half the cases, and also > > > > checking if this is needed in the port would require a > > > > __FreeBSD_version bump which is probably overkill for this bug. > > >=20 > > > And why is it overkill? I regularly see comments about not > > > wanting to bump __FreeBSD_version, but it's just an integer > > > (though presented as a fixed-point fraction). There is no > > > shortage and I never have understood why people are so hesitant > > > to change it when there is a real, even if fairly small benefit > > > from the bump. > >=20 > > Hmm. Alexander, what do you think? >=20 > Not being Alexander, but appeared on Cc:. >=20 > IMO, bumping __FreeBSD_version should not be done frivolous, and > routine bug fixes are definitely not the good reason to bump. >=20 > For one, users of HEAD or stable are assumed to run tip of the branch. > If you want defined point of the branch, use release. With this POV, > the usefulness of the bump for bug fix is only a week or two. >=20 > Second, bump of __FreeBSD_version signifies major incompatibility > between pre-bumped tree and current one. In the kernel, each bump of > version in HEAD means that new modules cannot be loaded into new > kernel. >=20 > Bumping for bug fixes is a misuse of the mechanism which was put there > to provide information about major changes in system. For small or > detectable items, use autoconf-like runtime (or build-time *) tests. >=20 > * - Usually, the tests must be run-time, and not build-time. This bug > is greatly amplified by use of __FreeBSD_version. The case that > initiated the discussion is probably the first time I ever saw the > when build-time test makes some sense. I agree with Konstantin and I do not see the point to bump the version just to serve fleeting needs of -stable or -current branch users - their problems will be gone with upgrade to the tip of the respective branch and this is the first thing they are expected to do before reporting a bug anyway. --=20 Alexander Kabaev --Sig_/CaBsWPFxGA19IQqehbrwp+F Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iD8DBQFQMl2uQ6z1jMm+XZYRAiksAJ4uOLssIr8Ns79NR5+Sflbogh6dHACdEL19 +1cir6jiiTHHFSpII+nZqjY= =VOZA -----END PGP SIGNATURE----- --Sig_/CaBsWPFxGA19IQqehbrwp+F--