From owner-p4-projects@FreeBSD.ORG Thu Jun 15 18:42:39 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 918B616A47B; Thu, 15 Jun 2006 18:42:39 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D39E16A41A for ; Thu, 15 Jun 2006 18:42:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id D969643D45 for ; Thu, 15 Jun 2006 18:42:38 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5FIgZgn049637; Thu, 15 Jun 2006 14:42:36 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John Birrell Date: Thu, 15 Jun 2006 14:33:24 -0400 User-Agent: KMail/1.9.1 References: <200606130047.k5D0liTa052536@repoman.freebsd.org> <200606130930.46610.jhb@freebsd.org> <20060614205205.GA86553@what-creek.com> In-Reply-To: <20060614205205.GA86553@what-creek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606151433.24652.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 15 Jun 2006 14:42:37 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1539/Wed Jun 14 10:21:49 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: perforce@freebsd.org Subject: Re: PERFORCE change 99099 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2006 18:42:39 -0000 On Wednesday 14 June 2006 16:52, John Birrell wrote: > On Tue, Jun 13, 2006 at 09:30:46AM -0400, John Baldwin wrote: > > On Monday 12 June 2006 20:47, John Birrell wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=99099 > > > > > > Change 99099 by jb@jb_freebsd2 on 2006/06/13 00:47:28 > > > > > > Add hooks for DTrace to register a function to be called when > > > the scheduler chooses a new thread to run. This is required for > > > DTrace vtime. > > > > You should probably do this in mi_switch() in kern_synch.c rather than > > in this macro. > > Looking further at this is seems that the code actually has to be > inserted into each scheduler just before the call to cpu_switch because > the schedulers are each capable of selecting a new thread right up > to that time (see sched_switch). Ah, yes, I didn't realize at first you needed to know what the new thread is. -- John Baldwin