From owner-svn-src-all@FreeBSD.ORG  Wed Mar 21 00:48:37 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4CC83106566C;
	Wed, 21 Mar 2012 00:48:37 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 2511E8FC16;
	Wed, 21 Mar 2012 00:48:37 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id E383C56209; Tue, 20 Mar 2012 19:48:36 -0500 (CDT)
Date: Tue, 20 Mar 2012 19:48:36 -0500
From: Mark Linimon <linimon@lonesome.com>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20120321004836.GB30795@lonesome.com>
References: <201203162319.q2GNJjx5039482@svn.freebsd.org>
	<201203201019.40486.jhb@freebsd.org>
	<CADLo839Ef3bu_14AdexOWapOacFLk3MM9HK-oNLmtA52Cc9C6w@mail.gmail.com>
	<201203201728.21049.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201203201728.21049.jhb@freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Doug Barton <dougb@freebsd.org>, svn-src-all@freebsd.org,
	Dimitry Andric <dim@freebsd.org>, src-committers@freebsd.org,
	Bruce Evans <brde@optusnet.com.au>, svn-src-head@freebsd.org,
	Chris Rees <utisoft@gmail.com>
Subject: Re: svn commit: r233052 - head/share/mk
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Mar 2012 00:48:37 -0000

The style in bsd.port.mk is not consistent.  (I know, this is shocking
for something that's at r1.706.)

Here's what I recall seeing in it, that I found readable:

.if defined(USE_GL)
. if ${USE_GL:L} == "yes"
USE_GL=     glu
. endif
. for _component in ${USE_GL}
.  if !defined(_GL_${_component}_LIB_DEPENDS) && \
        !defined(_GL_${_component}_RUN_DEPENDS)
IGNORE=     uses unknown GL component
.  else
LIB_DEPENDS+=   ${_GL_${_component}_LIB_DEPENDS}
RUN_DEPENDS+=   ${_GL_${_component}_RUN_DEPENDS}
.  endif
. endfor
.endif

Various other bits of ports/Mk/*.mk use this same indentation; others
use two spaces, tabs, ...

Unfortunately the counter-argument of "let's just go fix it to have one
style" is all the patches against bsd.port.mk that would then no longer
apply.

Personally, I'd like to see us pick a "recommended way for new code",
whether it's one or two spaces, whatever.  (8 spaces seems too much.)

mcl