From owner-svn-src-all@FreeBSD.ORG Tue Mar 31 16:02:28 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7DF32949; Tue, 31 Mar 2015 16:02:28 +0000 (UTC) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [IPv6:2607:fc50:1000:7400:216:3eff:fe72:314f]) by mx1.freebsd.org (Postfix) with ESMTP id 5D391A86; Tue, 31 Mar 2015 16:02:28 +0000 (UTC) Received: from marvin.lab.vangyzen.net (c-73-147-253-17.hsd1.va.comcast.net [73.147.253.17]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 2F93256467; Tue, 31 Mar 2015 11:02:27 -0500 (CDT) Message-ID: <551AC4BF.40106@FreeBSD.org> Date: Tue, 31 Mar 2015 12:01:03 -0400 From: Eric van Gyzen User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: John Baldwin , Randall Stewart Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <32487399.PTq7ESkWJT@ralph.baldwin.cx> <26047F0C-A975-4DAC-9077-31B5EC4902DA@netflix.com> <5710983.pHS9DoOdY8@ralph.baldwin.cx> In-Reply-To: <5710983.pHS9DoOdY8@ralph.baldwin.cx> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 16:02:28 -0000 >> Now as to the >> >> -1 -> NOCPU >> >> This is like pulling on a string on your sweater.. the only sensible solution that >> I could come up with after chatting with Lawrence is to add >> #include >> to everyone that uses the callout.h and does not have it already… (putting it into callout.h does not work) .. sigh.. >> >> Now for this cosmetic change I end up with the following changes (and as yet I have >> not built LINT or universe so there may be more).. I have spent about 2 hours on this >> so far and I can at least build a kernel with the change for amd64 :-0 >> >> Here is what has to change, do you really think that this is worth it? >> >> Note I did not look into moving NOCPU in proc.h it says it means no CPU is present >> which is sort of the meaning we want.. I am not sure if the define could be moved .. but >> that too may be yet another string... >> >> Is this worth it, or do you have another idea on how best to do this??? > > Ugh. :( I guess leave it at -1 for now. If you leave it as -1, you might add a /* NOCPU */ comment, for the sake of grep. (This could be a lost cause, for all I know, but it can't hurt.) > Another alternative would be to > move NOCPU to (at least for the kernel) if bde@ would allow it. > I don't think changing all those files is appropriate. > > (Also, seems like an odd place for NOCPU now, it should really be > in if not param.h. I understand why it was first added in proc.h, > but it is now used in many more places than just td_oncpu.) +1 Eric