From owner-svn-src-all@freebsd.org  Tue Nov 10 15:18:30 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00DEFA2AC1F;
 Tue, 10 Nov 2015 15:18:30 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BC0AE1F1F;
 Tue, 10 Nov 2015 15:18:29 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 7BEC11FE022;
 Tue, 10 Nov 2015 16:18:27 +0100 (CET)
Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys
To: Randall Stewart <rrs@netflix.com>
References: <201511101449.tAAEnXIi065747@repo.freebsd.org>
 <56420634.5060704@selasky.org>
 <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com>
Cc: Randall Ray Stewart <rrs@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <56420B2B.50301@selasky.org>
Date: Tue, 10 Nov 2015 16:20:11 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <19671573-5C8C-4E33-845B-791DA966E4A9@netflix.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Nov 2015 15:18:30 -0000

On 11/10/15 16:03, Randall Stewart wrote:
> And I disagree here Hans
>
> You don’t need that and it just adds more into the
> callout system that is not needed.

Hi,

It also makes debugging more easy, that you can see the last function 
call and argument. I.E. You should not have to clear the drain function 
pointer before calling the drain function.

Something else. Maybe you should bump the FreeBSD version, because 
callout_stop() is a macro, and you've changed its API by adding another 
argument to _callout_stop_safe(), to force a recompilation of KLD's. 
Else garbage will be passed into "drain" ...

--HPS