Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Sep 2023 13:18:32 -0700
From:      Xin Li <delphij@FreeBSD.org>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org>
Subject:   Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13.
Message-ID:  <f9e97e19-597d-c0ec-5a30-652a323b6cf4@FreeBSD.org>
In-Reply-To: <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org>
References:  <202309031849.383In8u2023677@gitrepo.freebsd.org> <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2023-09-03 12:39 PM, Jessica Clarke wrote:
> On 3 Sep 2023, at 19:49, Xin LI <delphij@FreeBSD.org> wrote:
>>
>> The branch stable/13 has been updated by delphij:
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=02183951bfb19fda7a199acaeb9223cd28f29de3
>>
>> commit 02183951bfb19fda7a199acaeb9223cd28f29de3
>> Author:     Xin LI <delphij@FreeBSD.org>
>> AuthorDate: 2023-09-03 18:49:02 +0000
>> Commit:     Xin LI <delphij@FreeBSD.org>
>> CommitDate: 2023-09-03 18:49:02 +0000
>>
>>     Fix build for FreeBSD 13.
>>
>>     The minigzip utility has been removed in FreeBSD 14 but still
>>     exists in FreeBSD 13. The upstream revision e9d5486e removed
>>     prototype definitions, rendering the code no longer compliant
>>     with WARNS=5.
> 
> Uh, what on earth is upstream doing? Has this been reported /
> complained about?

I've created a PR for this https://github.com/madler/zlib/pull/855 (by 
converting the functions to static ones).

Cheers,




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f9e97e19-597d-c0ec-5a30-652a323b6cf4>