From owner-svn-src-head@freebsd.org Fri Aug 23 16:48:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1427CC99B8 for ; Fri, 23 Aug 2019 16:48:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46FS5H5rTXz3yWy for ; Fri, 23 Aug 2019 16:48:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id b11so11785161qtp.10 for ; Fri, 23 Aug 2019 09:48:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IC68LVdpMR0Yro0lFdUjiuijwgzpquDdti2+hEmj7rQ=; b=D73JCq0d81rYy41rZNGPGJd8+e17GecKLa8erG1X2NhIcp+p0+B4lWXczRq+ufg3cQ cG+VuKAhWF1A1Wq5PoipSc3Zk3NZVrRIC2POJJ72SbOKCK/WhtW1acU9nrnyz4FC+xoj y+gu7Ujm6szldRbz4AOtl7g9vn2yDDrda3kPGD5DHR9TSpE8LXIz5ChoPoZn2YCdpWTd 99oWApyQ4YRQ88M+ExhoB2W1EqPDIrpQHWXpYvVq2o/goB7IDzfaDHPLL5EbuBrg4TvO 1Oc4OdngIr/LmPDEYheoWAyMG3K311fjDOBLilfdn5FJRgP/8pqKFRLs6VYGxXZw2elI kTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IC68LVdpMR0Yro0lFdUjiuijwgzpquDdti2+hEmj7rQ=; b=CapWHekrInUr6LH5AU2SIuC3PnrD4mAzPODGdlvgRz46PL5XlvZdoJZ51do9nwzRp8 zhaLpKCQ0SnUyJgQm/xY8Ax963s65YMpPauqHrJB9GKJfNCXdDDYA0iWyxJPQx3IfKf+ CZAe+jMDoyYMW9tnMlW7QrceWCecrvRi1TJwhUFPzKffgdSXD0CZ7gYESjNY1AENAKfg GAomwudhTi/xPNsfe0c/msGIUY5TqbTnhTd9KLq5+l6pduGWrOTGdGr2OaqzHZ1SHhbB M+t6Bg4yTLj2mtfDP1tU3pezdD5JA6f6CTx7DDNAWMMfTQHAtmzyEoGyS+6Oa8w9SUmH ZVag== X-Gm-Message-State: APjAAAUvLoCosvZXf2FLzhkuS+CU8WwIvKO2OaAva5R8cUaDIPopvkUV w79KvlnyBzZhafQUosBAkyyJ7La2wtjqMOmwm2xDTVAdbcpSgw== X-Google-Smtp-Source: APXvYqwQuLehHRz8Qhhmg+aaUR0DMtnnJO5+kAtasHKsFLmHKWtwa+MtLsgwf7p05lj3O1S58P7pbJuVQmuoK7cuDLg= X-Received: by 2002:aed:3c45:: with SMTP id u5mr5642267qte.175.1566578898198; Fri, 23 Aug 2019 09:48:18 -0700 (PDT) MIME-Version: 1.0 References: <201908220002.x7M028Jh070116@repo.freebsd.org> <0b9d1aa1-d328-30bc-b939-f1407e236855@FreeBSD.org> <3EE09B22-254B-4415-8865-D9542122ACA5@FreeBSD.org> In-Reply-To: <3EE09B22-254B-4415-8865-D9542122ACA5@FreeBSD.org> From: Warner Losh Date: Fri, 23 Aug 2019 10:48:06 -0600 Message-ID: Subject: Re: svn commit: r351364 - in head/sys: crypto/blowfish crypto/chacha20 crypto/des opencrypto To: "Bjoern A. Zeeb" Cc: Li-Wen Hsu , John Baldwin , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46FS5H5rTXz3yWy X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=D73JCq0d; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::833) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.91 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; RCVD_IN_DNSWL_NONE(0.00)[3.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.92)[ip: (-9.33), ipnet: 2607:f8b0::/32(-2.88), asn: 15169(-2.34), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2019 16:48:21 -0000 On Fri, Aug 23, 2019 at 10:10 AM Bjoern A. Zeeb wrote: > On 23 Aug 2019, at 15:53, Warner Losh wrote: > > > Sorry for top posting... > > > > I had planned this for next week, but I think give this insanity of > > this > > patch, we should do it now: turn off -Werror for gcc 4.2.1 > > > > https://reviews.freebsd.org/D21378 > > > > has the review. There's no benefit to these head-scratcher changes > > when we > > can get the same benefit by ignoring gcc 4.2.1 errors as discussed on > > arch@. > > That brings me to a different question: why does this build > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/lastBuild/ not fail > despite rendering the warnings > There's a lot of -Wno-error and -Wno-error=XXX sprinkled in our build for gcc 4.2.1 today, so we see the warnings but aren't stopped by them. My changes take a big hammer and add a global -Wno-error to CFLAGS last to make this the behavior on gcc 4.2.1 platforms. Warner