From owner-freebsd-current@FreeBSD.ORG Mon Apr 28 01:52:49 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 612271065678; Mon, 28 Apr 2008 01:52:49 +0000 (UTC) (envelope-from haro@kgt.co.jp) Received: from mail02.kgt.co.jp (dmz02.kgt.co.jp [210.141.246.82]) by mx1.freebsd.org (Postfix) with ESMTP id 0DD6F8FC24; Mon, 28 Apr 2008 01:52:48 +0000 (UTC) (envelope-from haro@kgt.co.jp) Received: from navgw.tt.kgt.co.jp (unknown [210.141.246.71]) by mail02.kgt.co.jp (Postfix) with ESMTP id 52C7C3C3D1E1; Mon, 28 Apr 2008 10:52:47 +0900 (JST) Received: from localhost (posh.tt.kgt.co.jp [192.168.15.51]) by navgw.tt.kgt.co.jp (Postfix) with ESMTP id E0BBE47718; Mon, 28 Apr 2008 10:52:46 +0900 (JST) Date: Mon, 28 Apr 2008 10:52:43 +0900 (JST) Message-Id: <20080428.105243.114275877.haro@kgt.co.jp> To: sam@freebsd.org From: haro@kgt.co.jp In-Reply-To: <4814C302.7080705@freebsd.org> References: <20080427.220905.113455362.haro@kgt.co.jp> <790a9fff0804270857n643c6ed9p3954abec41c12516@mail.gmail.com> <4814C302.7080705@freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: swhetzel@gmail.com, freebsd-current@freebsd.org Subject: Re: iwi0 "need multicast update callback" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Apr 2008 01:52:49 -0000 From: Sam Leffler Date: Sun, 27 Apr 2008 11:16:34 -0700 :Scot Hetzel wrote: :> On Sun, Apr 27, 2008 at 8:09 AM, wrote: :> :>> Hi list, :>> :>> After updating my pc today, I'm getting following message on the console. :>> As it seems to be working ok, but is there any way to get rid of it? :>> :>> iwi0: need multicast update callback :>> :>> :> I noticed this with the ndis driver also. I searched the code and :> found that this is coming from the null_update_mcast function in :> /sys/net80211/ieee802.c :> :> To get rid of this notification will require updating the iwi and ndis :> drivers to seperate multicast update and promisc update into seperate :> functions: :> :> ic->ic_update_mcast = null_update_mcast; :> ic->ic_update_promisc = null_update_promisc; :> : :> /* :> * Synchronize flag bit state in the parent ifnet structure :> * according to the state of all vap ifnet's. This is used, :> * for example, to handle IFF_PROMISC and IFF_ALLMULTI. :> */ :> void :> ieee80211_syncifflag_locked(struct ieee80211com *ic, int flag) :> :> This is to allow the ieee80211_syncifflag_locked function to update :> the parent ifnet structure. :> :> Search the other wireless drivers (i.e ath) on how the conversion was made. :> :> :These messages are a reminder to fill in missing functionality and can :be somewhat ignored. It may be possible to have the default mcast :filter handler mark the ALLMULTI flag and fallback to the 802.3 layer :for multicast filtering but I wasn't convinced that worked right so left :the printf reminder. : :Of course the right solution is to push the mcast address list to the :device. Thank you for the info. I'll look into the iwi driver for what I can do about it. Regards, Haro =----------------------------------------------------------------------- _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| KGT Inc. /|\ |_| |_|_| 2-8-8 Shinjuku, Shinjuku-ku Tokyo 160-0022, Japan Tel: +81-3-3225-0767 Fax: +81-3-3225-0740