From owner-freebsd-hackers@FreeBSD.ORG  Wed May 27 11:07:17 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D03F1065686
	for <freebsd-hackers@freebsd.org>; Wed, 27 May 2009 11:07:17 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id F1BD08FC20
	for <freebsd-hackers@freebsd.org>; Wed, 27 May 2009 11:07:16 +0000 (UTC)
	(envelope-from des@des.no)
Received: from ds4.des.no (cm-84.215.252.34.getinternet.no [84.215.252.34])
	by smtp.des.no (Postfix) with ESMTP id 02F996D41D;
	Wed, 27 May 2009 13:07:16 +0200 (CEST)
Received: by ds4.des.no (Postfix, from userid 1001)
	id E2DE5844CD; Wed, 27 May 2009 13:07:15 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: rea-fbsd@codelabs.ru
References: <23727599.post@talk.nabble.com> <86prdvipwe.fsf@ds4.des.no>
	<0vGjPHEq7MqxjtFmBufY+mBxlR4@7oUjtCwN654QcDr16CH+kAk8bJg>
Date: Wed, 27 May 2009 13:07:15 +0200
In-Reply-To: <0vGjPHEq7MqxjtFmBufY+mBxlR4@7oUjtCwN654QcDr16CH+kAk8bJg> (Eygene
	Ryabinkin's message of "Wed, 27 May 2009 13:52:21 +0400")
Message-ID: <86vdnmiz30.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@freebsd.org, Jakub Lach <jakub_lach@mailplus.pl>
Subject: Re: FYI Lighttpd 1.4.23 /kernel (trailing '/' on regular file
	symlink) vulnerability
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 May 2009 11:07:17 -0000

Eygene Ryabinkin <rea-fbsd@codelabs.ru> writes:
> May be the attached patch will fix the thing?=20

I'm not entirely convinced.  Try the regression test I wrote
(head/tools/regression/vfs/trailing_slash.t)

> It adds an additional flag, but this was the only thing I was able to
> invent to avoid ABI breakage.

The flag is a good idea, but I think the correct place to handle this is
in namei(), around line 290 (don't be fooled by the comment on line 270;
the code inside the if statement is for the *non*-symlink case).

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no