From owner-freebsd-dtrace@freebsd.org Thu May 11 17:56:15 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4179AD680E3 for ; Thu, 11 May 2017 17:56:15 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE0541059; Thu, 11 May 2017 17:56:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt0-x229.google.com with SMTP id v27so11244245qtg.2; Thu, 11 May 2017 10:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GQO1QhjScQqdl25ZIc3LCpD53X+0xGWW8HPBdD/sQW0=; b=mnpeHMVWtJCu29HeNEXvDV8flNYDKIOFd25X1tkU7hCckaWAb6ZqBXZtfIn5w8p7Wx B8tN9Skk5+DGHlm6h+aXZoqLBf8jZUDocWPUueNUpRqL8RMXBAf+SZKExfgfih/uffOL 1qteoRkaQOHDW3HsyGANCmumUspYJZ3mvfF+HAw9y7MP3UgK7QF2UyMXb1TOhZ52zd6C XjuEi0532/zW6V+H+thc6t6Ftp5tKQsMS9swTaB7M2txI199BU7wkNCecdHDHM0Rqn2R cr8V7ZIB8AJNVO9ytBi68e43Ws4tNBPadlx9KbMMfEYIB85t+eylQS571B/0V5aDFNvA oCWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GQO1QhjScQqdl25ZIc3LCpD53X+0xGWW8HPBdD/sQW0=; b=jvil9b8NVZtbR/eW7kJTwzS6DeXZKP8ryThpbnrqdjumEw5F01fPiXpZZio5oG51l1 D3hO+BZMvyuzN8sKG3GHFZ1xUC4GMYC4FCc250GcFwg5yNRxEyfcNelFqGJR+rZdr68o GLtyuyh/x2wZhSJYTZuS5ZXwahic93tR1/4+AM3vRRUIlYv9ULahlgGZd+i21fm5+6ia 7GCRFx8zwyUHtk7gSEevbY/LovNTkX6u3m557IHRnHGgtif1oCimyB6MTpK5jfMdy9BJ gs7bzPLI8c2uBaebGboiKYbHvtCDmAZCxbbXYDHgJ4PtNxZ1DUz1YDov7nckbYYLaxCi Axyg== X-Gm-Message-State: AODbwcBl1OSq/i+8fwTk93hzuhXtYYfFMCgJNezoQj8n1Jt59d/tkI+t k7md3YoZ7uOrkA== X-Received: by 10.200.50.45 with SMTP id x42mr51994qta.23.1494525353807; Thu, 11 May 2017 10:55:53 -0700 (PDT) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id d21sm557410qke.62.2017.05.11.10.55.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2017 10:55:52 -0700 (PDT) Sender: Mark Johnston Date: Thu, 11 May 2017 10:55:21 -0700 From: Mark Johnston To: smh@FreeBSD.org Cc: freebsd-dtrace@freebsd.org, Andreas Longwitz Subject: Re: DTrace boken in FreeBSD 10.3 Stable Message-ID: <20170511175521.GC2950@wkstn-mjohnston.west.isilon.com> References: <5912E417.5070404@incore.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5912E417.5070404@incore.de> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 17:56:15 -0000 On Wed, May 10, 2017 at 11:57:43AM +0200, Andreas Longwitz wrote: > After upgrade FreeBSD 10.3 from r307955 to r317936 DTrace is broken: > > The output of > dtrace -n 'dtrace:::BEGIN { printf("Hello FreeBSD!\n"); }' > gives > dtrace: invalid probe specifier dtrace:::BEGIN { printf("Hello > FreeBSD!\n"); }: "/usr/lib/dtrace/ip.d", line 245: m_data is not a > member of struct mbuf > > The file ip.d was replaced with commit of Revision 317375. Using the > previus version of the file /usr/lib/dtrace/ip.d lets DTrace work again. Steven, could you please take a look at this? I think it was incorrect to merge the changes to in_kdtrace.c since the probe sites in the TCP code have not been correspondingly updated.