From owner-cvs-all Wed Nov 13 20:54: 1 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5D05737B406; Wed, 13 Nov 2002 20:53:59 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id E37B743E88; Wed, 13 Nov 2002 20:53:57 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id gAE4rqpk082739; Wed, 13 Nov 2002 21:53:52 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 13 Nov 2002 21:53:46 -0700 (MST) Message-Id: <20021113.215346.90827277.imp@bsdimp.com> To: sobomax@FreeBSD.org Cc: silby@silby.com, njl@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sleep sleep.c From: "M. Warner Losh" In-Reply-To: <20021113204503.GI9006@vega.vega.com> References: <200211132012.gADKCQxr062768@repoman.freebsd.org> <20021113204503.GI9006@vega.vega.com> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20021113204503.GI9006@vega.vega.com> Maxim Sobolev writes: : On Wed, Nov 13, 2002 at 03:32:13PM -0500, Mike Silbersack wrote: : > : > On Wed, 13 Nov 2002, Nate Lawson wrote: : > : > > njl 2002/11/13 12:12:26 PST : > > : > > Modified files: : > > bin/sleep sleep.c : > > Log: : > > Remove getopt and strtol dependencies, reducing size of static exe. : > > Preserve older desired behavior, accept [+-]*[0-9]*\.[0-9]* : > > Remove a few unnecessary casts. : > : > Please don't commit crap like this. While having smaller binaries might : > be nice, being entered into an obfuscated C contest is not one of the : > goals of FreeBSD. : : I fully agree - HDD space is pretty cheap today, while embedded folks : should use other means to reduce footprint (e.g crunchgen). Actually : in the case of crunchgen this commit worsens situation, as the code : is no longer shared. It also makes the dynamic binary larger for the folks that have / and /usr on the same partition and dynamically link /sbin and /bin. Much more bang for the buck that these silly micro-optimizations. So this is a negative thing as far as I'm concerned. :-( Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message