Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2002 21:53:46 -0700 (MST)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        sobomax@FreeBSD.org
Cc:        silby@silby.com, njl@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/bin/sleep sleep.c
Message-ID:  <20021113.215346.90827277.imp@bsdimp.com>
In-Reply-To: <20021113204503.GI9006@vega.vega.com>
References:  <200211132012.gADKCQxr062768@repoman.freebsd.org> <Pine.BSF.4.44.0211131528010.32919-100000@niwun.pair.com> <20021113204503.GI9006@vega.vega.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20021113204503.GI9006@vega.vega.com>
            Maxim Sobolev <sobomax@FreeBSD.org> writes:
: On Wed, Nov 13, 2002 at 03:32:13PM -0500, Mike Silbersack wrote:
: > 
: > On Wed, 13 Nov 2002, Nate Lawson wrote:
: > 
: > > njl         2002/11/13 12:12:26 PST
: > >
: > >   Modified files:
: > >     bin/sleep            sleep.c
: > >   Log:
: > >   Remove getopt and strtol dependencies, reducing size of static exe.
: > >   Preserve older desired behavior, accept [+-]*[0-9]*\.[0-9]*
: > >   Remove a few unnecessary casts.
: > 
: > Please don't commit crap like this.  While having smaller binaries might
: > be nice, being entered into an obfuscated C contest is not one of the
: > goals of FreeBSD.
: 
: I fully agree - HDD space is pretty cheap today, while embedded folks
: should use other means to reduce footprint (e.g crunchgen). Actually
: in the case of crunchgen this commit worsens situation, as the code
: is no longer shared.

It also makes the dynamic binary larger for the folks that have / and
/usr on the same partition and dynamically link /sbin and /bin.  Much
more bang for the buck that these silly micro-optimizations.  So this
is a negative thing as far as I'm concerned. :-(

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021113.215346.90827277.imp>