From owner-cvs-ports@FreeBSD.ORG Sat Apr 14 08:47:53 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F444106564A for ; Sat, 14 Apr 2012 08:47:53 +0000 (UTC) (envelope-from timur@bat.ru) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 081468FC0A for ; Sat, 14 Apr 2012 08:47:52 +0000 (UTC) Received: by wern13 with SMTP id n13so3186017wer.13 for ; Sat, 14 Apr 2012 01:47:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=h5os12p8r3s/Q5G9vaJQ8SbRmvnwBgitg8ocAmWO7aw=; b=ZhICIzWJdqLAUC1VZp7/fVBWdDb9Ar3lWWwtl9dmvsPfEX8fWra3V6fHg04hFplVyR bBAB9cleCxAgwqjxHgmJqVMS+WSZDE1uyJctQGv8JC8miIrSweN5+AH5x4riQer1OfkS mnW4Bei91Hdj2RRsbGhAHtCgyLceQAktFZY5MwJBvihvE1B0s6flBzJ09rH0dDS4GVW+ bnTZvJ48kgtSjVkQ4fZZpI3/ZzAauA4j7seX7ceavkPt/Uxrk5xBsKnBnmnUTTKz4sUy OFzWs4gkH4yGNmBxYxCFGCcg/IiwuTHq0huwdhy1tGG8nkWcnB5Z3x5ec4lMC+fx6RBC kk5A== Received: by 10.180.104.230 with SMTP id gh6mr2699210wib.22.1334392864121; Sat, 14 Apr 2012 01:41:04 -0700 (PDT) MIME-Version: 1.0 Sender: timur@bat.ru Received: by 10.223.127.206 with HTTP; Sat, 14 Apr 2012 01:40:43 -0700 (PDT) In-Reply-To: <201204130916.q3D9G0an068975@repoman.freebsd.org> References: <201204130916.q3D9G0an068975@repoman.freebsd.org> From: "Timur I. Bakeyev" Date: Sat, 14 Apr 2012 10:40:43 +0200 X-Google-Sender-Auth: UhIiD-4bLZPa85qiE9_jBC0-PlE Message-ID: To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQnl33mwE8awStHJHR+iRRtjOtDlGrRhsATtaxRQfVL47KhBvzgX8MhQIABCtG5D5fFJrYBj Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/net/samba34 Makefile ports/net/samba34/files samba.in ports/net/samba35 Makefile ports/net/samba35/files samba.in ports/net/samba36 Makefile ports/net/samba36/files samba.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2012 08:47:53 -0000 I'm really speechless... Do we, for fuck sake have any policy for updating ports which still do have alive maintainers? I was surprised to find out that Doug changed startup script in January without any notice, but now AGAIN!!! Not a note to maintainer, nothing - it's starts to become a tradition between ports commiters? This whole matter around port updates makes me really disgusted and kill all the willingness to do any port maintenance - if any one can come and screw up what ever you did, spending your precious time - whats the point to contribute at all? Really annoyed, Timur Bakeyev. On Fri, Apr 13, 2012 at 11:16 AM, Doug Barton wrote: > dougb =A0 =A0 =A0 2012-04-13 09:16:00 UTC > > =A0FreeBSD ports repository > > =A0Modified files: > =A0 =A0net/samba34 =A0 =A0 =A0 =A0 =A0Makefile > =A0 =A0net/samba34/files =A0 =A0samba.in > =A0 =A0net/samba35 =A0 =A0 =A0 =A0 =A0Makefile > =A0 =A0net/samba35/files =A0 =A0samba.in > =A0 =A0net/samba36 =A0 =A0 =A0 =A0 =A0Makefile > =A0 =A0net/samba36/files =A0 =A0samba.in > =A0Log: > =A0The samba rc.d script uses some clever tricks to start (up to) 3 diffe= rent > =A0services using the same script. As a result it resets rcvar several ti= mes > =A0in order to process the options for each service. > > =A0The changes I made on 2012/01/14 to facilitate the removal of set_rc_v= ar() > =A0from HEAD were effective in the case where the WINBIND option was off = (the > =A0case that I tested) because that causes the related portions of the rc= .d > =A0script to be removed completely on install. However, if installed from= a > =A0package, or installed using the the default OPTIONS, WINBIND is on, wh= ich > =A0caused the last known rcvar to be winbind_enable. > > =A0Since the common case seems to be for users to use samba_enable (which > =A0only enables smb_and nmb_ by default) the fact that rcvar=3Dwinbind_en= able, > =A0but that knob is off, caused the startup script to trip on a totally > =A0unrelated portion of rc.subr. > > =A0So the fix is to move processing of the winbind_ stuff first, which le= aves > =A0the last known rcvar as smb_enable. Since running nmb without smb is a > =A0very unlikely scenario, this should be safe for the common case, as we= ll > =A0as safe if the user enables winbind_. > > =A0Apologies all around for not catching this sooner, and thanks to the u= sers > =A0who reported the problem and stuck with me while I debugged it. > > =A0Bump PORTREVISION since this fix is needed for the common case, as > =A0configured for the package. > > =A0Revision =A0Changes =A0 =A0Path > =A01.14 =A0 =A0 =A0+1 -1 =A0 =A0 =A0ports/net/samba34/Makefile > =A01.6 =A0 =A0 =A0 +5 -5 =A0 =A0 =A0ports/net/samba34/files/samba.in > =A01.11 =A0 =A0 =A0+1 -1 =A0 =A0 =A0ports/net/samba35/Makefile > =A01.3 =A0 =A0 =A0 +5 -5 =A0 =A0 =A0ports/net/samba35/files/samba.in > =A01.6 =A0 =A0 =A0 +1 -1 =A0 =A0 =A0ports/net/samba36/Makefile > =A01.3 =A0 =A0 =A0 +5 -5 =A0 =A0 =A0ports/net/samba36/files/samba.in