From nobody Wed Jun 24 16:49:37 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glnwP0Mm4z6jTXn; Wed, 24 Jun 2026 16:49:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glnwN62hPz3Q3f; Wed, 24 Jun 2026 16:49:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782319780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czpTks5jFTUF6Milo9PgHToMEKPfDnqRyCCD45x3qUU=; b=cn9c+VnI9ROIFacT1lLXpEziIuO90hdyoCtOqdIWsh5fa92/Zxkv8MXBHDNTTyBeadO7av o7ZCrhs9UM5uJTIScq6/VFaMVK6G4ggAEb3yhe7gDv74Y7XUhcHwlSSO0OBTKEDfp1eMNj +eWYFwlgaWX1Y1tHuCs1i5LtNCxZ8VnSFNCj91NR9nwxcSZpvnxlQMcWtrVJ8crGOSQGCM Bug775zmaVsN3Z4ZcKL50kurfeTvjB9j3Qm9b9D0ZoXjdqyeTh1HASh2Kwr7yxUhQq1acj 9TqTIoBjR1fbFy7+zet/XT5JMseDUDGcYkDY+0LORyklzoSOaLTIzRZPotEdYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782319780; a=rsa-sha256; cv=none; b=sJNaVbSiBxmXSWyviWhGD2VOFdjMMoTkEQcbBOtjwn6O0T0Erl8cbiYTDBrEzBPAd9b6NQ 6lVNIENhOciDv52nRvAFk34JAI36y4G+apBiFVcP8c1CczrFYtBMeCVvM86Xk+5m76koh6 x1VahDnVsVK30/EmQoSYsfZU4NNsYNSHlX2Wb7PCpmZrihCEvz2lUryb+/0nlm24XkLQ8h VhGazYXGodOM5tRHNZsDfJGJaIv1NLG33iPXw8CfWTlfZnRNMHpz8MlyodV4xLouAlRX2q zm3R0BIG+a+TjcB5n30e3LEVj/nSrk0mOk8/AlL9T4g9VWqMdyIasfVArXmNIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782319780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=czpTks5jFTUF6Milo9PgHToMEKPfDnqRyCCD45x3qUU=; b=CY1P0jzTFYmGErzMvUMnMVzRCCm/V5+RmmELBM9J2Qgpw9dJ7rSv5Ywhl52/DclLKBzZas PBOflEVW52MD89UvLq+L6cEDUZkLQaqCTmhuzyh2SzL8CpHv3W/v19tlcY5/Ej1PCDsmoe Z9MetWZKqhK1YFEibVlqOXQMaKdOjirgUeCBBC6CJLMKHbu7HwSZ3FWnTuXfiFDfV8TP+U PahKDmoPaslerYzov6g4EZ52VXlZHu/zLIUhUeD44cjE/XjcP1iECYeetQE2ULZ1QtEvZQ a2NyEJoouhSwAU68/w/UqQRtDQrd5LFWXN0pPpT+AaZvEXknZfgstnsvKRsWTw== Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 8D2F019075; Wed, 24 Jun 2026 16:49:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from localhost (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id EE0CF988C; Wed, 24 Jun 2026 09:49:39 -0700 (PDT) X-Virus-Scanned: amavis at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by localhost (mail.xzibition.com [172.31.3.2]) (amavis, port 10026) with LMTP id OBNuCZnbQL47; Wed, 24 Jun 2026 09:49:37 -0700 (PDT) Message-ID: <4827de8d-ffbf-415a-aeca-4ec383dab315@FreeBSD.org> DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com CA9A6988A Date: Wed, 24 Jun 2026 09:49:37 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally From: Bryan Drewery To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> <88c10bd6-0c00-4033-98d2-f910b466efc8@FreeBSD.org> <9998a345-f864-466b-ac38-8603fc5ff359@FreeBSD.org> Content-Language: en-US In-Reply-To: <9998a345-f864-466b-ac38-8603fc5ff359@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/24/26 9:45 AM, Bryan Drewery wrote: > On 6/24/26 9:33 AM, Alan Somers wrote: >> On Wed, Jun 24, 2026 at 10:04 AM Bryan Drewery >> wrote: >>> On 6/23/26 7:54 AM, Alan Somers wrote: >>>> The branch main has been updated by asomers: >>>> >>>> URL: >>>> https://cgit.FreeBSD.org/src/commit/?id=e03ed9daeb49fffa1d16b8d00240c65e92650d01 >>>> >>>> commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 >>>> Author:     Jitendra Bhati >>>> AuthorDate: 2026-06-12 17:07:55 +0000 >>>> Commit:     Alan Somers >>>> CommitDate: 2026-06-23 14:53:56 +0000 >>>> >>>>       fts: refactor to use fd-relative operations internally >>>> >>>>       Replace all _open() calls with _openat() in __fts_open(), >>>> fts_read(), >>>>       and fts_children(). >>>> >>>>       Add fts_dirfd to FTSENT. Callers can use >>>>       openat(ent->fts_dirfd, ent->fts_name, ...) to access files >>>>       safely without relying on fts_accpath, which enables: >>>> >>>>       1. Capsicum capability mode where path-based operations fail >>>>       2. Security-sensitive programs that avoid TOCTOU races >>>> >>>>       Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in >>>>       fts_ufslinks() when fts_dirfd is valid, falling back to >>>> statfs() for >>>>       root-level entries where fts_dirfd is -1 >>>> >>>>       This is a preparatory change for fts_openat() which will allow >>>>       callers to provide a pre-opened directory fd, enabling fts(3) >>>>       traversal inside Capsicum capability mode. >>>> >>>>       Sponsored by:   Google LLC (GSoC 2026) >>>>       Reviewed by:    asomers, jillest >>>>       MFC after:      2 weeks >>>>       Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 >>> Someone on IRC reported they bisected a Poudriere breakage to this >>> commit. >> Really?  I'd be interested to see that log.  Also, Jitendra is already >> working on the fix. >> > I asked for more details but haven't heard back yet. It is probably > because Poudriere ships static binaries so is hitting the ABI break. > > Sorry for the spam. I misremembered, it's not static but they are pre-compiled dynamic binaries expecting libc to match the headers built with.