From owner-cvs-all  Mon Oct  4  5:47:10 1999
Delivered-To: cvs-all@freebsd.org
Received: from lor.watermarkgroup.com (lor.watermarkgroup.com [207.202.73.33])
	by hub.freebsd.org (Postfix) with ESMTP
	id 761DD14F18; Mon,  4 Oct 1999 05:47:05 -0700 (PDT)
	(envelope-from luoqi@watermarkgroup.com)
Received: (from luoqi@localhost)
	by lor.watermarkgroup.com (8.8.8/8.8.8) id IAA29554;
	Mon, 4 Oct 1999 08:47:01 -0400 (EDT)
	(envelope-from luoqi)
Date: Mon, 4 Oct 1999 08:47:01 -0400 (EDT)
From: Luoqi Chen <luoqi@watermarkgroup.com>
Message-Id: <199910041247.IAA29554@lor.watermarkgroup.com>
To: alc@cs.rice.edu, eivind@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/include atomic.h
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> On Sun, Oct 03, 1999 at 04:35:44PM -0500, Alan Cox wrote:
> > On Sun, Oct 03, 1999 at 02:15:25PM -0700, Eivind Eklund wrote:
> > > eivind      1999/10/03 14:15:25 PDT
> > > 
> > >   Modified files:
> > >     sys/i386/include     atomic.h 
> > >   Log:
> > >   Allow compilation with older versions of GCC, in order to make it possible
> > >   to bootstrap and work with -current from older versions of FreeBSD.
> > >   
> > 
> > I'm curious.  Why didn't you base this change on revision 1.1.2.1?  The
> > implementation that you used is known to produce non-atomic code under
> > gcc 2.7.2.x.
> 
> Because I didn't notice 1.1.2.1; I reviewed the diffs backwards along
> -current only :-( I'll fix it tomorrow - I'm too tired now to want to
> mess around in the code.
> 
> Eivind.
> 
Please also append another underscore to __GNUC_MINOR_, and shouldn't the
gcc minor version test be ">= 9" instead of "> 9"?

-lq


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message