Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Jun 2023 16:39:40 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: d3251842321e - main - arm64: Remove struct arm64_frame
Message-ID:  <202306151639.35FGdeZX085890@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=d3251842321e7a5ac8bbb2aec128328cd10f3a84

commit d3251842321e7a5ac8bbb2aec128328cd10f3a84
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2023-06-15 16:10:44 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2023-06-15 16:38:45 +0000

    arm64: Remove struct arm64_frame
    
    It was used in one place and was added specifically to support dtrace
    stack unwinding code.  Write an equivalent expression using struct
    unwind_state instead.  No functional change intended.
    
    Reviewed by:    andrew
    MFC after:      1 week
    Sponsored by:   Innovate UK
    Differential Revision:  https://reviews.freebsd.org/D40538
---
 sys/arm64/include/frame.h                | 5 -----
 sys/cddl/dev/dtrace/aarch64/dtrace_isa.c | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/sys/arm64/include/frame.h b/sys/arm64/include/frame.h
index fc10f8574161..c838193bee9e 100644
--- a/sys/arm64/include/frame.h
+++ b/sys/arm64/include/frame.h
@@ -51,11 +51,6 @@ struct trapframe {
 	uint64_t tf_x[30];
 };
 
-struct arm64_frame {
-	struct arm64_frame	*f_frame;
-	u_long			f_retaddr;
-};
-
 /*
  * Signal frame, pushed onto the user stack.
  */
diff --git a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
index 1641ad246419..d8ef65cfb6d9 100644
--- a/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
+++ b/sys/cddl/dev/dtrace/aarch64/dtrace_isa.c
@@ -133,7 +133,7 @@ dtrace_getustack_common(uint64_t *pcstack, int pcstack_limit, uintptr_t pc,
 			break;
 
 		pc = dtrace_fuword64((void *)(fp +
-		    offsetof(struct arm64_frame, f_retaddr)));
+		    offsetof(struct unwind_state, pc)));
 		fp = dtrace_fuword64((void *)fp);
 
 		if (fp == oldfp) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202306151639.35FGdeZX085890>