From owner-svn-src-head@freebsd.org Fri Mar 15 05:55:35 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05307153ECC3; Fri, 15 Mar 2019 05:55:35 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6AF2289D7A; Fri, 15 Mar 2019 05:55:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f43.google.com with SMTP id u12so7254323iop.11; Thu, 14 Mar 2019 22:55:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=Hc7eafKegjIcWhbxEmu4Bq46F+n/blxgItwkwuO07UU=; b=mHnAQBEHCIPE+0SCALpVNsIwQGjfI4rriASFauDgsEqog9H7Su0ZVcLmMSgLg0Yqgc 0jwC7GzTC1DCOhjkw42aQhqRq0EP4Atfegl3wiJ+LU+ksRENXOYAPnEQ+Fmrtx5OcoOh cbP8zh5+vChDqnz6/Vaix8zANdiKWMNH/RtKmEDQgyifLA2B4b1YnNwnlf2FbPcpT8Ru XJc4RQz0iU0VC9xWbLMYVqDo79oUFVlvd7NWxUgIcdgmsCS4fW/1pjJ01l9gqrlSNaOk ggQQMEUvkXiHa+gfNq3Yv0Wc0J813/M6YWkvYydM4iYaJLYoTnQg+r1flUH+f4Q7/WBn b8HQ== X-Gm-Message-State: APjAAAWxb69TtpmKWmAFkiOeG205EM7G/s79gbO8D5HKFBOfmKHN5miI oZv1Tt2xqEmwEP/9HgVy7QeSvKud X-Google-Smtp-Source: APXvYqx5WisBqumKy8YuOZRu0s6DdnOlNt5OWljieISYF9iVNFzC0zDVf4LUKJF1gBEXGgpBkDbo1g== X-Received: by 2002:a6b:7505:: with SMTP id l5mr1072247ioh.244.1552627473414; Thu, 14 Mar 2019 22:24:33 -0700 (PDT) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com. [209.85.166.54]) by smtp.gmail.com with ESMTPSA id w19sm554246ita.33.2019.03.14.22.24.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 22:24:32 -0700 (PDT) Received: by mail-io1-f54.google.com with SMTP id b9so561348iot.13; Thu, 14 Mar 2019 22:24:32 -0700 (PDT) X-Received: by 2002:a6b:c84e:: with SMTP id y75mr1141627iof.107.1552627472298; Thu, 14 Mar 2019 22:24:32 -0700 (PDT) MIME-Version: 1.0 References: <201903150211.x2F2BSai079898@repo.freebsd.org> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer Date: Thu, 14 Mar 2019 22:24:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: Andrew Thompson Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6AF2289D7A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 05:55:35 -0000 On Thu, Mar 14, 2019 at 8:06 PM Andrew Thompson wrote: > > On Fri, 15 Mar 2019 at 15:11, Chuck Tuffli wrote: >> bzero(&pciecap, sizeof(pciecap)); ... >> + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > If the message you say 'set the bit' but you are overwriting the whole variable, is this intended? Looks like it was zero before. So yeah, it sets the bit.