Date: Mon, 3 Feb 2014 11:38:57 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, Tijl Coosemans <tijl@FreeBSD.org>, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r341510 - head/lang/libobjc2 Message-ID: <20140203103857.GR54904@ithaqua.etoilebsd.net> In-Reply-To: <FC14339A-AC0E-47B5-A821-42398E154889@FreeBSD.org> References: <201401280813.s0S8DcHf067201@svn.freebsd.org> <20140203111542.426f69be@kalimero.tijl.coosemans.org> <FC14339A-AC0E-47B5-A821-42398E154889@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nHJAUhyIZkPvF01C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Feb 03, 2014 at 10:33:23AM +0000, David Chisnall wrote:
> On 3 Feb 2014, at 10:15, Tijl Coosemans <tijl@FreeBSD.org> wrote:
> >=20
> > The port is currently broken. By removing the bsd.port.pre.mk include
> > -DCMAKE_C_COMPILER:STRING=3D"${CC}" in Uses/cmake.mk now comes after the
> > -DCMAKE_C_COMPILER=3D${CLANG} here so it doesn't have any effect. Same=
for
> > CXX.
> >=20
> > Instead of putting .include <bsd.port.pre.mk> back, maybe the port shou=
ld
> > define CC=3D${CLANG} CXX=3D${CLANGXX} and remove the second CMAKE_ARGS =
line?
>=20
> Indeed. This is currently a bit of a hack. Ideally, we should remove th=
at ugliness and have a USES=3Dcompiler:objc (ideally objc-1.7 to specify th=
e runtime ABI version), which would give us clang from either ports or base=
depending on whether there is one in base and what its version is.
>=20
I did a quick fix, I'm all for a compiler:objc !!
regards,
Bapt
--nHJAUhyIZkPvF01C
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (FreeBSD)
iEYEARECAAYFAlLvccEACgkQ8kTtMUmk6EwOgwCeMl1bfpnsnxddcAHgl6UH5jpw
CsUAniYoReZfFUr7AZOHpurt+GotGb9/
=Xk3j
-----END PGP SIGNATURE-----
--nHJAUhyIZkPvF01C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140203103857.GR54904>