From owner-freebsd-current@FreeBSD.ORG Fri Sep 26 17:37:57 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50C7D16A4B3; Fri, 26 Sep 2003 17:37:57 -0700 (PDT) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3464C44017; Fri, 26 Sep 2003 17:37:56 -0700 (PDT) (envelope-from grog@lemis.com) Received: from blackwater.lemis.com (blackwater.lemis.com [192.109.197.80]) by ozlabs.org (Postfix) with ESMTP id B6F0D2BD41; Sat, 27 Sep 2003 10:37:53 +1000 (EST) Received: by blackwater.lemis.com (Postfix, from userid 1004) id 1CEC751836; Sat, 27 Sep 2003 10:07:52 +0930 (CST) Date: Sat, 27 Sep 2003 10:07:52 +0930 From: Greg 'groggy' Lehey To: Robert Watson Message-ID: <20030927003752.GS16008@wantadilla.lemis.com> References: <16244.40636.428865.644209@canoe.dclg.ca> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xPLL5cPndR2UZ7Mw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 cc: freebsd-current@freebsd.org cc: David Gilbert Subject: Re: recent changes prohibit vinum swap. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Sep 2003 00:37:57 -0000 --xPLL5cPndR2UZ7Mw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Friday, 26 September 2003 at 18:38:48 -0400, Robert Watson wrote: > > On Fri, 26 Sep 2003, David Gilbert wrote: > >> Recent changes to -CURRENT prohibit vinum swap: >> >> [1:6:306]root@mu:~> swapon /dev/vinum/swapmu swapon: /dev/vinum/swapmu: >> Operation not supported by device > > In order to support swapping, Vinum will need to be modified to use struct > disk and the disk(9) API, rather than exposing its storage devices > directly via struct cdevsw and make_dev(9). I.e., Vinum probably needs to > start approaching things as "disks" rather than "devices", a distinction > that's becoming more mature in -CURRENT. > > From a quick read of vinumconfig.c, I'm guessing this wouldn't be hard to > implement. Some subset of struct sd, struct plex, and struct volume will > need to start holding a struct disk instance which would be passed to > disk_create() instead of a call to make_dev(). Much of the remainder will > just consist of a bit of tweaking to make Vinum extract its data from > bp->bio_disk->d_drv1 instead of bp->b_dev, replacing the ioctl dev_t > argument with a disk argument, etc. I'll take a look at this soon. If somebody else wants to look first, please let me know. The introduction of GEOM means quite a shake-up in the Vinum structure. > I recently noticed that Vinum may be averse to blocksizes other than > 512 bytes. It shouldn't be. There's never been any dependency on it. > Or at least, I can get Vinum mirrors up and running on md devices > backed to memory, but not to swap, and the usual reason for problems > on that front is the 4k blocksize for swap-backed md devices. I've had a number of problems with md devices. This one may be that Vinum is presenting a 512 byte block size upwards instead of the 4 kB that it should be showing. Again, I'll take a look. > I also noticed that the vinum commandline tool is a bit > devfs-unfriendly, or at least, it gets pretty verbose about how all > the files/directories it wants to create are already present. It > could be that a test for devfs conditionally causing a test for > EEXIST would go a long way in muffling the somewhat loud complaining > :-). I'm not sure I understand this. Can you give me a concrete example? Greg -- See complete headers for address and phone numbers. NOTE: Due to the currently active Microsoft-based worms, I am limiting all incoming mail to 131,072 bytes. This is enough for normal mail, but not for large attachments. Please send these as URLs. --xPLL5cPndR2UZ7Mw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.0 (FreeBSD) iD8DBQE/dNvgIubykFB6QiMRAoJgAJ9mFmRvvHv9IJm9OGhYxN1ZcZQtTgCbBv/1 0ocCEzVDprDMCs7E9s0jfC8= =9kFQ -----END PGP SIGNATURE----- --xPLL5cPndR2UZ7Mw--