From owner-freebsd-net@freebsd.org Mon Jun 26 20:17:04 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A74C1D909A7 for ; Mon, 26 Jun 2017 20:17:04 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4062D3E7F for ; Mon, 26 Jun 2017 20:17:04 +0000 (UTC) (envelope-from matt.joras@gmail.com) Received: by mail-wm0-x22b.google.com with SMTP id b184so7796342wme.1 for ; Mon, 26 Jun 2017 13:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kCIixj2ovWBwkL9MmSIhc0QM4ggwVVYQUtZEucG6Up4=; b=Pw+9V+kq3ThS59SV1plS/aG1j73bqK9IkfdEcBOQsLspS+WKeaEypmPUVdwMIOxwri 5/N/auT410f5CEg4NTwEvHEzoukaSsfxKCxecc5rpTNOYsnLNgA6QPkUC7U3gd1nFwkb ZvGjr6wEn4EGtRGMlBIQ2frjuS/MXoKlobmvQMrmZXFdl4pi7y069/ynmJFaj+Ccf90L NcsS5T/SVwb8P7is7P8t6xNVOzWNGH/NwsqIjtVZqVr0A9rDxM6ceTC7aq0IYCAze32y tZQn+yceUkcnNzh/rwBGnAM2F0YEWx2aANw/m/5r+YRqSnKscHNWBDP62rn5SD43B1j8 eWjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kCIixj2ovWBwkL9MmSIhc0QM4ggwVVYQUtZEucG6Up4=; b=eEj+rGd0ldlB/FfPw4H1ftoO3JqkX/CKXR1kr6JiLGS5Zs4W7pErGQ1z2WgwxgZoYt BBATKRSpIIl26PYxT6SKqDNcwM1iqxXnC3zeBuRtk/TljFjQ52MLc7y9R4MnPCrGd1Ce 2LW/m3HZ0NKWL/nyg5LpR4bO5b48MQs1mDbXnoYxOEU+rviCnlNq+6HJWgN+YQArbfAG VItzmoQ/y+wsgpF40YaucKUUxg5ySrHqtdEjnf0Oq6LaeIjRGw5dP/jx+NyLO0cSrjkW 3NgLbnSAT5PcwUv8MgN0iZm0Sn6RZXavUU1vDA2h79w/gkGXLZh8Y6KGtxn7mn2XNkxy o3pQ== X-Gm-Message-State: AKS2vOy/SXMTY2HgsX2TPtq0x0RcmryQupwcLObrAjV246nNiDLXmGWy tiYBKZ/tGuZ6fihdI443hOGfJGLPmFyJ X-Received: by 10.28.113.21 with SMTP id m21mr928597wmc.80.1498508222626; Mon, 26 Jun 2017 13:17:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.160.42 with HTTP; Mon, 26 Jun 2017 13:17:02 -0700 (PDT) From: Matt Joras Date: Mon, 26 Jun 2017 13:17:02 -0700 Message-ID: Subject: Request for reviewers for vlan(4) locking improvements To: FreeBSD Net Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 20:17:04 -0000 Hello, I am looking for people to give feedback on a review I've opened to improve the locking in vlan(4). Anyone who's done a fair amount of destroying vlan interfaces on live systems has probably run into panics in if_vlan. This is because there is no real synchronization to prevent a vlan interface from being destroyed while there are mbufs in the network going through its functions. Isilon's customers have hit panics like this, so I've reworked the locking to make destroying vlans safe on live systems, and fixed every instance of unsafe access I could find. If anyone has an interest in this work please review the revision: https://reviews.freebsd.org/D11370 Thanks, Matt Joras