Date: Fri, 16 Mar 2012 23:30:17 GMT From: dfilter@FreeBSD.ORG (dfilter service) To: freebsd-bugs@FreeBSD.org Subject: Re: kern/166190: commit references a PR Message-ID: <201203162330.q2GNUHqq005729@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/166190; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: kern/166190: commit references a PR Date: Fri, 16 Mar 2012 23:24:36 +0000 (UTC) Author: adrian Date: Fri Mar 16 23:24:27 2012 New Revision: 233053 URL: http://svn.freebsd.org/changeset/base/233053 Log: Fix a couple of debugging outputs. * printf -> device_printf * print the buffer pointer and sequence number for any buffer that wasn't correctly tidied up before it was freed. This is to aid in some current SMP TX debugging stalls. PR: kern/166190 Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ============================================================================== --- head/sys/dev/ath/if_ath.c Fri Mar 16 23:19:45 2012 (r233052) +++ head/sys/dev/ath/if_ath.c Fri Mar 16 23:24:27 2012 (r233053) @@ -4795,10 +4795,16 @@ ath_tx_default_comp(struct ath_softc *sc if (bf->bf_state.bfs_dobaw) device_printf(sc->sc_dev, - "%s: dobaw should've been cleared!\n", __func__); + "%s: bf %p: seqno %d: dobaw should've been cleared!\n", + __func__, + bf, + SEQNO(bf->bf_state.bfs_seqno)); if (bf->bf_next != NULL) device_printf(sc->sc_dev, - "%s: bf_next not NULL!\n", __func__); + "%s: bf %p: seqno %d: bf_next not NULL!\n", + __func__, + bf, + SEQNO(bf->bf_state.bfs_seqno)); /* * Do any tx complete callback. Note this must @@ -5352,8 +5358,11 @@ ath_stoprecv(struct ath_softc *sc, int d struct ath_buf *bf; u_int ix; - printf("%s: rx queue %p, link %p\n", __func__, - (caddr_t)(uintptr_t) ath_hal_getrxbuf(ah), sc->sc_rxlink); + device_printf(sc->sc_dev, + "%s: rx queue %p, link %p\n", + __func__, + (caddr_t)(uintptr_t) ath_hal_getrxbuf(ah), + sc->sc_rxlink); ix = 0; TAILQ_FOREACH(bf, &sc->sc_rxbuf, bf_list) { struct ath_desc *ds = bf->bf_desc; _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203162330.q2GNUHqq005729>