Date: Tue, 18 Jan 2011 21:40:24 +0300 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/154121: [patch] Mk/bsd.licenses.mk: post r217309 dialog(1) doesn't support --hline option Message-ID: <86k4i2vyw7.fsf@gmail.com> Resent-Message-ID: <201101181850.p0IIo8RJ024379@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 154121
>Category: ports
>Synopsis: [patch] Mk/bsd.licenses.mk: post r217309 dialog(1) doesn't support --hline option
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: portmgr
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jan 18 18:50:07 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Anonymous
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
/head@r217454M
>Description:
>How-To-Repeat:
1. use /head or devel/cdialog
2. run `make LICENSES_ASK=' on any port with `dual' or `multi' license
$ cd audio/libgme && make LICENSES_ASK=
===> License LGPL21 LGPL3 needs confirmation, will ask later
===> Extracting for libgme-0.5.5
=> SHA256 Checksum OK for game-music-emu-0.5.5.tbz2.
===> Converting DOS text files to UNIX text files
*** Error code 255
$ dialog --hline foo
Error: Unknown option --hline.
>Fix:
I couldn't find anything similar to --hline so use --title as it's
supported by both versions.
--- a.diff begins here ---
Index: Mk/bsd.licenses.mk
===================================================================
RCS file: /a/.cvsup/ports/Mk/bsd.licenses.mk,v
retrieving revision 1.5
diff -u -p -r1.5 bsd.licenses.mk
--- Mk/bsd.licenses.mk 7 Jan 2011 01:29:45 -0000 1.5
+++ Mk/bsd.licenses.mk 18 Jan 2011 17:57:18 -0000
@@ -609,7 +609,7 @@ ${_LICENSE_COOKIE}:
. for lic in ${_LICENSE_TO_ASK}
@${ECHO_CMD} "${lic}:${_LICENSE_FILE_${lic}}" >> ${_LICENSE_ASK_DATA}
. endfor
- @menu_cmd="${DIALOG} --hline \"This port requires you to accept at least one license\" --menu \"License for ${PKGNAME} (dual)\" 21 70 15"; \
+ @menu_cmd="${DIALOG} --title \"This port requires you to accept at least one license\" --menu \"License for ${PKGNAME} (dual)\" 21 70 15"; \
tmpfile=$$(mktemp -t portlicenses); \
for lic in ${_LICENSE_TO_ASK}; do \
menu_cmd="$${menu_cmd} VIEW_$${lic} \"View the license $${lic}\" USE_$${lic} \"Accept the license $${lic}\""; \
@@ -634,7 +634,7 @@ ${_LICENSE_COOKIE}:
. for lic in ${_LICENSE_TO_ASK}
@${ECHO_CMD} "${lic}:${_LICENSE_FILE_${lic}}" >> ${_LICENSE_ASK_DATA}
. endfor
- @menu_cmd="${DIALOG} --hline \"This port requires you to accept all mentioned licenses\" --menu \"License for ${PKGNAME} (multi)\" 21 70 15"; \
+ @menu_cmd="${DIALOG} --title \"This port requires you to accept all mentioned licenses\" --menu \"License for ${PKGNAME} (multi)\" 21 70 15"; \
tmpfile=$$(mktemp -t portlicenses); \
for lic in ${_LICENSE_TO_ASK}; do \
menu_cmd="$${menu_cmd} VIEW_$${lic} \"View the license $${lic}\""; \
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86k4i2vyw7.fsf>