From owner-svn-src-all@freebsd.org Tue Oct 20 15:15:32 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42999A1AA4B; Tue, 20 Oct 2015 15:15:32 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F37B130A; Tue, 20 Oct 2015 15:15:31 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id t9KFFUa2067067; Tue, 20 Oct 2015 15:15:30 GMT (envelope-from ian@FreeBSD.org) Received: (from ian@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id t9KFFUgC067066; Tue, 20 Oct 2015 15:15:30 GMT (envelope-from ian@FreeBSD.org) Message-Id: <201510201515.t9KFFUgC067066@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ian set sender to ian@FreeBSD.org using -f From: Ian Lepore Date: Tue, 20 Oct 2015 15:15:30 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r289631 - head/sys/arm/arm X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 15:15:32 -0000 Author: ian Date: Tue Oct 20 15:15:30 2015 New Revision: 289631 URL: https://svnweb.freebsd.org/changeset/base/289631 Log: Uncomment some rather important code that was commented out for benchmarking. Normally this routine is supposed to loop until the PIC returns a "no more interrupts pending" indication. I had commented that out to do just one interrupt per invokation to do some timing tests. Spotted by: Svata Kraus Pointy Hat: ian Modified: head/sys/arm/arm/gic.c Modified: head/sys/arm/arm/gic.c ============================================================================== --- head/sys/arm/arm/gic.c Tue Oct 20 13:47:36 2015 (r289630) +++ head/sys/arm/arm/gic.c Tue Oct 20 15:15:30 2015 (r289631) @@ -554,10 +554,10 @@ dispatch_irq: arm_irq_dispatch(isrc, tf); next_irq: -// arm_irq_memory_barrier(irq); /* XXX */ -// irq_active_reg = gic_c_read_4(sc, GICC_IAR); -// irq = irq_active_reg & 0x3FF; - if (0 && irq < sc->nirqs) + arm_irq_memory_barrier(irq); + irq_active_reg = gic_c_read_4(sc, GICC_IAR); + irq = irq_active_reg & 0x3FF; + if (irq < sc->nirqs) goto dispatch_irq; return (FILTER_HANDLED);