From owner-p4-projects@FreeBSD.ORG  Thu Jul 19 03:53:25 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B7F9F16A405; Thu, 19 Jul 2007 03:53:24 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7454E16A402;
	Thu, 19 Jul 2007 03:53:24 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from mojo.ru (mojo.ru [84.252.152.63])
	by mx1.freebsd.org (Postfix) with ESMTP id D45CB13C4AC;
	Thu, 19 Jul 2007 03:53:23 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from [192.168.0.16] (nc-76-4-28-21.dhcp.embarqhsd.net [76.4.28.21])
	(authenticated bits=0)
	by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l6J3rNbA017158
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 19 Jul 2007 07:53:26 +0400
Message-ID: <469EE028.4010401@FreeBSD.org>
Date: Wed, 18 Jul 2007 23:53:12 -0400
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
Organization: Google Summer of Code 2007 Student @ The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB;
	rv:1.7.5) Gecko/20041217
X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su
MIME-Version: 1.0
To: Maxim Zhuravlev <thioretic@FreeBSD.org>
References: <200707181728.l6IHSHCa048858@repoman.freebsd.org>
In-Reply-To: <200707181728.l6IHSHCa048858@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@FreeBSD.org>,
	"Constantine A. Murenin" <cnst@FreeBSD.org>
Subject: Re: PERFORCE change 123699 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2007 03:53:25 -0000

On 18/07/2007 13:28, Maxim Zhuravlev wrote:
> http://perforce.freebsd.org/chv.cgi?CH=123699
> 
> Change 123699 by thioretic@thioretic on 2007/07/18 17:27:28
> 
> 	Just some load code for DR_REQDEV drivers.
> 
> Affected files ...
> 
> .. //depot/projects/soc2007/thioretic_gidl/kern/subr_bus.c#17 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2007/thioretic_gidl/kern/subr_bus.c#17 (text+ko) ====
> 
> @@ -4662,8 +4662,8 @@
>  	drv_internal_t drv_intnl;
>  	kobj_class_t driver;
>  	char* parents[];
> -	int count=0, isfilter;
> -	device_t dev;
> +	int count=0, isfilter, devcount;
> +	device_t dev, *devices;
>  
>  	dmd = (struct driver_module_data *)arg;
>  	drv_intnl = dmd->dmd_driver;
> @@ -4702,14 +4702,14 @@
>  			parentname = driver->baseclasses[0]->name;
>  			*dmd->dmd_devclass =
>  				devclass_find_internal(driver->name,
> -				    parentname, TRUE);
> +				    parentname, TRUE, FALSE);
>  		} else {
>  			*dmd->dmd_devclass =
> -				devclass_find_internal(driver->name, 0, TRUE);
> +				devclass_find_internal(driver->name, 0, TRUE, FALSR);

typo? If FALSR is not a typo but an actual constant, I would suggest 
renaming it in such a way that it won't look like it is meant to be 
typed as FALSE. :)

Cheers,
Constantine.