From owner-svn-src-head@freebsd.org Wed May 9 19:13:32 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC740FC8F1E; Wed, 9 May 2018 19:13:32 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EEEF27360E; Wed, 9 May 2018 19:13:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id GUWhfMmNnuYopGUWjf4KjZ; Wed, 09 May 2018 13:13:25 -0600 X-Authority-Analysis: v=2.3 cv=GopsBH9C c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=VUJBJC2UJ8kA:10 a=VxmjJ2MpAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=L-z-6Hhc_PHMCk-cKloA:9 a=CjuIK1q_8ugA:10 a=SgE0gsHR3q8A:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 2854034B; Wed, 9 May 2018 12:13:23 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w49JD7AV017696; Wed, 9 May 2018 12:13:07 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w49JD7oE017688; Wed, 9 May 2018 12:13:07 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201805091913.w49JD7oE017688@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: John Baldwin , Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333393 - head/sys/contrib/ipfilter/netinet In-Reply-To: Message from Cy Schubert of "Wed, 09 May 2018 12:07:34 -0700." <201805091907.w49J7Y0L003669@slippy.cwsent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 09 May 2018 12:13:07 -0700 X-CMAE-Envelope: MS4wfPtz642UAUZYAnveHdHMH9jFXoReXbKPhMYVxe9L+G9I4cbiMtjOcdxN8sr5jrN1aRlGG9i8xWTIiCZkkxt5oTb9UsPaaNrtT046XnVUHNo4EsgAEQsk qdwbPIiJ3rsfkT11shYrSXG5ZULr4aoK+AE2Oy+v4pwh2u/qgbthWgn8IAsaPF8N7FOXa1Ocf5kcqF1g0XoDXsdGDcie/MqS5ImaGXonWWAX90Yf3GY/Tucj SOhjm5q6Mu5jX3pGKWIZxMXiXDnXRxCFFu8muy5+ef0p+l7s5tnqVipnTNxgKFKGcZCQYYMm8qHQLd/V93kMjdPZy5c1eXyDD/CzzTfU3dk= X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 19:13:32 -0000 In message <201805091907.w49J7Y0L003669@slippy.cwsent.com>, Cy Schubert writes: > In message <4065288.o9QKfFzp22@ralph.baldwin.cx>, John Baldwin writes: > > On Wednesday, May 09, 2018 02:07:09 AM Cy Schubert wrote: > > > Author: cy > > > Date: Wed May 9 02:07:09 2018 > > > New Revision: 333393 > > > URL: https://svnweb.freebsd.org/changeset/base/333393 > > > > > > Log: > > > Document intentional fallthrough. (CID 976535) > > > > > > MFC after: 1 week > > > > > > Modified: > > > head/sys/contrib/ipfilter/netinet/fil.c > > > > > > Modified: head/sys/contrib/ipfilter/netinet/fil.c > > > ========================================================================= > == > > === > > > --- head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:02:58 201 > 8 > > (r333392) > > > +++ head/sys/contrib/ipfilter/netinet/fil.c Wed May 9 02:07:09 201 > 8 > > (r333393) > > > @@ -1299,6 +1299,7 @@ ipf_pr_icmp(fin) > > > } > > > } > > > #endif > > > + /* fallthrough is intentional */ > > > case ICMP_SOURCEQUENCH : > > > case ICMP_REDIRECT : > > > case ICMP_TIMXCEED : > > > > Hmm, normal FreeBSD style here is to use /* FALLTHROUGH */, and there are > > three other instances of that style in ipfilter already (and none others > > using this comment style). > > Thanks John. It's been fixed in r333393. s/r333393/r333427/ -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.