From nobody Tue Jun 30 17:20:36 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gqVKK2RxYz6jY2B for ; Tue, 30 Jun 2026 17:20:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gqVKJ5Nc0z3qWc for ; Tue, 30 Jun 2026 17:20:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782840036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qYekwYqt8HLT54Z93pCwzX+TtUBdIqhsNSZkWxsF9EI=; b=KpLPsqOeiPqdWjZ/egMb3/UpGqGm401xrwYkfZ/2ct48bGGG5axngLfRNc0RF7RgzGQciv wWaPv6UXwYIV9AE37CBVHixsFU/+RrMZtR7j/0qmv2bW9XYgspq01EM5xrWTFKurpMJpye xZ9L8WpBgL+bezkIVga7ufNTljX01PFiXle/XABF41zV2ZMxKlg14mq5Q+a1NGCmTZ+s+w X22esQDTp4PdquKIB39wU0VJcnWwubSTLMT6ThY9kLES4L9ge7oRM4mUWw+MSxbZjIw5wy cF+nwOITLsM9JXbiB0NSslmH4feBHSlIeZvOf/xtMirh2JeqYeYSgA+TC+AMng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782840036; a=rsa-sha256; cv=none; b=bCuTqDeMLtI1kt3LbAwtTofH0Yp+VuCsv4Q9OJTP8FH7U/OBp20vmfjJqMGwrFha1ioW6u jcYE4zeShk52V/GDc5jdZsXAoS7W6AUaGpbTXUch1rIszF+1eQKs7pCmtqf21xl9jYyVTb p+57NKCccmJwuZN48yNiIKqVoaCYdwdhWdAfVATG/uN8Atul/yknxG7rEPgrnhfLWyxQC4 76bkbbxLBbUMAxKLtBYWCGovCjlxCshhbNwbqLtBvCuXbTINUILaEe8FUczcopN6DKCmgh yg0LDsrEnptM2sMy8BRQLGogSfQNK+O1moEmHcXwMk7hUTJUY3VxehuY74NBmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782840036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qYekwYqt8HLT54Z93pCwzX+TtUBdIqhsNSZkWxsF9EI=; b=WZWr9tENDt2zWJNZvE0mURj13ZEUGxNrWQqMQKS+ZAickqHkqKc3uz6Eth99F2kWSg2zRf yXI9YYjYaldXr9t8RlxLk2OzjJJNdxOveW4JPQWjpUjNooSLzSVUclGrJAKrH2jsxB/phg Wq/Xdn8j10lVhQCZXVrX1t5wglDxNLOPCggAMe/dP+PKJxVzqhjaWIlOtRrR+G9UCxgsso V6Xb9PONXPa7z+O6PF3hJCYQWBluZtDoR4vGVtRcpg21eSZ/9c3OA3zubkXaCqYHFwxtlK yTxpJrbS6yo4OymfdLC8gfRD3jbtzDwUkN37sl6An/kYRAK9DomOE4HG5quPCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gqVKJ4JJjztDV for ; Tue, 30 Jun 2026 17:20:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45644 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 30 Jun 2026 17:20:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: d6e382c17691 - releng/14.3 - posixshm: Disallow truncation of largepage objects List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.3 X-Git-Reftype: branch X-Git-Commit: d6e382c17691eee21f7b4907ffd41d622af4200b Auto-Submitted: auto-generated Date: Tue, 30 Jun 2026 17:20:36 +0000 Message-Id: <6a43fae4.45644.253446e9@gitrepo.freebsd.org> The branch releng/14.3 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d6e382c17691eee21f7b4907ffd41d622af4200b commit d6e382c17691eee21f7b4907ffd41d622af4200b Author: Mark Johnston AuthorDate: 2026-06-23 22:47:02 +0000 Commit: Mark Johnston CommitDate: 2026-06-30 02:32:01 +0000 posixshm: Disallow truncation of largepage objects We correctly handled ftruncate(), but not open(O_TRUNC). Add a regression test. Approved by: so Security: FreeBSD-SA-26:44.posixshm Security: CVE-2026-49428 Reported by: Chris Jarrett-Davies Reviewed by: kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57831 --- sys/kern/uipc_shm.c | 8 +++----- tests/sys/posixshm/posixshm_test.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 41 insertions(+), 5 deletions(-) diff --git a/sys/kern/uipc_shm.c b/sys/kern/uipc_shm.c index 5849569f2dfc..b3dd7a91d473 100644 --- a/sys/kern/uipc_shm.c +++ b/sys/kern/uipc_shm.c @@ -824,7 +824,7 @@ shm_dotruncate_largepage(struct shmfd *shmfd, off_t length, void *rl_cookie) vm_pindex_t oldobjsz __unused; int aflags, error, i, psind, try; - KASSERT(length >= 0, ("shm_dotruncate: length < 0")); + KASSERT(length >= 0, ("shm_dotruncate_largepage: length < 0")); object = shmfd->shm_object; VM_OBJECT_ASSERT_WLOCKED(object); rangelock_cookie_assert(rl_cookie, RA_WLOCKED); @@ -1344,15 +1344,13 @@ kern_shm_open2(struct thread *td, const char *userpath, int flags, mode_t mode, if (error == 0 && (flags & (O_ACCMODE | O_TRUNC)) == (O_RDWR | O_TRUNC)) { - VM_OBJECT_WLOCK(shmfd->shm_object); #ifdef MAC error = mac_posixshm_check_truncate( - td->td_ucred, fp->f_cred, shmfd); + td->td_ucred, fp->f_cred, shmfd); if (error == 0) #endif - error = shm_dotruncate_locked(shmfd, 0, + error = shm_dotruncate_cookie(shmfd, 0, rl_cookie); - VM_OBJECT_WUNLOCK(shmfd->shm_object); } if (error == 0) { /* diff --git a/tests/sys/posixshm/posixshm_test.c b/tests/sys/posixshm/posixshm_test.c index dfcb5a72fefb..c792a85de9e3 100644 --- a/tests/sys/posixshm/posixshm_test.c +++ b/tests/sys/posixshm/posixshm_test.c @@ -2151,6 +2151,43 @@ ATF_TC_BODY(largepage_reopen, tc) "close failed; errno=%d", errno); } +ATF_TC_WITHOUT_HEAD(largepage_truncate); +ATF_TC_BODY(largepage_truncate, tc) +{ + size_t ps[MAXPAGESIZES]; + int fd, psind; + + (void)pagesizes(ps); + psind = 1; + + gen_test_path(); + fd = shm_create_largepage(test_path, O_CREAT | O_RDWR, psind, + SHM_LARGEPAGE_ALLOC_DEFAULT, 0600); + if (fd < 0 && errno == ENOTTY) + atf_tc_skip("no large page support"); + ATF_REQUIRE_MSG(fd >= 0, "shm_create_largepage failed; error=%d", errno); + + ATF_REQUIRE_MSG(ftruncate(fd, ps[psind]) == 0, + "ftruncate failed; error=%d", errno); + + ATF_REQUIRE_MSG(close(fd) == 0, "close failed; error=%d", errno); + + fd = shm_open(test_path, O_RDWR | O_TRUNC, 0); + ATF_REQUIRE_MSG(fd == -1, "shm_open(O_TRUNC) should have failed"); + ATF_REQUIRE_ERRNO(ENOTSUP, fd == -1); + + fd = shm_open(test_path, O_RDWR, 0); + ATF_REQUIRE_MSG(fd >= 0, "shm_open failed; error=%d", errno); + + ATF_REQUIRE_MSG(ftruncate(fd, ps[psind]) == 0, + "ftruncate to same size failed; error=%d", errno); + + ATF_REQUIRE_MSG(shm_unlink(test_path) == 0, + "shm_unlink failed; errno=%d", errno); + ATF_REQUIRE_MSG(close(fd) == 0, + "close failed; errno=%d", errno); +} + ATF_TP_ADD_TCS(tp) { ATF_TP_ADD_TC(tp, remap_object); @@ -2202,6 +2239,7 @@ ATF_TP_ADD_TCS(tp) ATF_TP_ADD_TC(tp, largepage_pkru); #endif ATF_TP_ADD_TC(tp, largepage_reopen); + ATF_TP_ADD_TC(tp, largepage_truncate); return (atf_no_error()); }