From owner-freebsd-acpi@FreeBSD.ORG Sat Apr 20 01:44:51 2013 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A46E9C3D; Sat, 20 Apr 2013 01:44:51 +0000 (UTC) (envelope-from robert.moore@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx1.freebsd.org (Postfix) with ESMTP id 50E7E922; Sat, 20 Apr 2013 01:44:50 +0000 (UTC) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 19 Apr 2013 18:44:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,513,1363158000"; d="scan'208";a="325236284" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by fmsmga002.fm.intel.com with ESMTP; 19 Apr 2013 18:44:42 -0700 Received: from fmsmsx153.amr.corp.intel.com ([169.254.9.79]) by FMSMSX103.amr.corp.intel.com ([169.254.3.111]) with mapi id 14.01.0355.002; Fri, 19 Apr 2013 18:44:42 -0700 From: "Moore, Robert" To: Benjamin Lee Subject: RE: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Topic: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 in legacy IRQ resource type) Thread-Index: AQHOPG391d2djyxEFEWgLAw8ZTDWIJjeIoGAgABQL4CAABLrgIAAD0UAgAAIawD//4zvYIAAf2gA//+UG8CAAHjlAP//kbwQAAFR74A= Date: Sat, 20 Apr 2013 01:44:42 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E36FE42EFF@FMSMSX153.amr.corp.intel.com> References: <20130418124940.47e3618a@b1c1l1.com> <201304191131.49433.jhb@freebsd.org> <20130419131849.7357c8f6@b1c1l1.com> <201304191726.31089.jhb@freebsd.org> <20130419152110.213c7fbb@b1c1l1.com> <20130419155118.7bafe9fc@b1c1l1.com> <94F2FBAB4432B54E8AACC7DFDE6C92E36FE42E28@FMSMSX153.amr.corp.intel.com> <20130419163528.204bf3ff@b1c1l1.com> <94F2FBAB4432B54E8AACC7DFDE6C92E36FE42EA2@FMSMSX153.amr.corp.intel.com> <20130419172200.45d8601b@b1c1l1.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "freebsd-acpi@freebsd.org" , "Guan, Chao" , "Zheng, Lv" X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2013 01:44:51 -0000 Disassembling the DSDT, we have this code in the _SRS execution path: Method (SRSA, 1, Serialized) { CreateWordField (Arg0, 0x05, INZ6) This code causes the main exception that was first reported: ACPI Error: Field [INZ6] at 56 exceeds Buffer [NULL] size 48 (bits) (201304= 18/dsopcode-326) [AcpiExec] Exception AE_AML_BUFFER_LIMIT during execution of method [SRSA] = Opcode [CreateWordField] @4 This code should not be a WORD field, it needs to be a BYTE field. This is = because the incoming buffer (Arg0) is exactly 6 bytes long -- so a WORD fie= ld at offset 5 will overrun the buffer. It looks like the code is attempting to access the last byte of the resourc= e descriptor, which is the second byte of the EndTag. Here is the fixed code: Method (SRSA, 1, Serialized) { CreateByteField (Arg0, 0x05, INZ6) Recompiling the DSDT and executing resource command, there are no errors: - resource \_SB_.PCI0.AUBA Device: \_SB_.PCI0.AUBA Evaluating _CRS rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 InternalLe= ngth 0C rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 InternalLe= ngth 0C [00] IRQ Resource Descriptor Length : 03 Triggering : Level Polarity : ActiveLow Sharing : Shared Interrupt Count : 00 Interrupt List : [01] EndTag Resource Resource Conversion Comparison: rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 InternalLe= ngth 10 rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 InternalLe= ngth 0C Evaluating _SRS Evaluating _PRS rscalc-0663 [04] RsGetListLength : Type 89, AmlLength 15 InternalLe= ngth 28 rslist-0217 [05] RsConvertAmlToResource: Type 89, AmlLength 15 InternalLe= ngth 28 rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 InternalLe= ngth 0C [00] Extended IRQ Resource Type : ResourceConsumer Triggering : Level Polarity : ActiveLow Sharing : Shared Resource Source Index : 00 Resource Source : [Not Specified] Interrupt Count : 04 Dword00 : 00000014 Dword01 : 00000015 Dword02 : 00000016 Dword03 : 00000017 [01] EndTag Resource So, this is obviously a rather serious bug in the DSDT that will need to be= addressed by the vendor. Chances are, there are a few more issues like thi= s in the code. As far as workarounds -- I'm sorry, but we can't allow a buffer overrun, an= d we can't "guess" what the code is really attempting to do. The correct ex= ecution is an abort with the exception AE_AML_BUFFER_LIMIT. I don't see any issues with the resource lengths, but I will double-check. Bob > -----Original Message----- > From: Moore, Robert > Sent: Friday, April 19, 2013 5:52 PM > To: 'Benjamin Lee' > Cc: John Baldwin; freebsd-acpi@freebsd.org; Zheng, Lv; Guan, Chao > Subject: RE: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ 20 > in legacy IRQ resource type) >=20 > I was able to quickly reproduce the _CRS/_SRS problem with the AUBA > device. I would imagine that this would fail on Windows also, as the basi= c > model of read(_CRS)/modify/write(_SRS) is fairly standard. Unless > something else is going on, of course. >=20 > Our debugger has a command to do this: >=20 >=20 > - resource \_SB_.PCI0.AUBA >=20 > Device: \_SB_.PCI0.AUBA > Evaluating _CRS > rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 > InternalLength 0C > rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 > InternalLength 0C >=20 > [00] IRQ Resource > Descriptor Length : 03 > Triggering : Level > Polarity : ActiveLow > Sharing : Shared > Interrupt Count : 00 > Interrupt List : >=20 > [01] EndTag Resource > Resource Conversion Comparison: > rscalc-0663 [04] RsGetListLength : Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 20, AmlLength 04 > InternalLength 10 > rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 > InternalLength 0C Evaluating _SRS ACPI Error: Field [INZ6] at 56 exceeds > Buffer [NULL] size 48 (bits) (20130418/dsopcode-326) [AcpiExec] Exception > AE_AML_BUFFER_LIMIT during execution of method [SRSA] Opcode > [CreateWordField] @4 >=20 > **** Exception AE_AML_BUFFER_LIMIT during execution of method > [\_SB_.PCI0.SRSA] (Node 004B7B50) >=20 > Method Execution Stack: > Method [SRSA] executing: [SRSA] @00000 #008B: CreateWordField (Arg0, > 0x05, INZ6) > Method [_SRS] executing: Call to method [\_SB_.PCI0.SRSA] (Node > 004B7B50) >=20 > Local Variables for method [SRSA]: > Local0: 00000000 > Local1: 00000000 > Local2: 00000000 > Local3: 00000000 > Local4: 00000000 > Local5: 00000000 > Local6: 00000000 > Local7: 00000000 >=20 > Arguments for Method [SRSA]: (1 arguments defined, max concurrency =3D 0= ) > Arg0: 004F4840 Buffer(6) 23 00 00 18 79 00 > Arg1: 00000000 > Arg2: 00000000 > Arg3: 00000000 > Arg4: 00000000 > Arg5: 00000000 > Arg6: 00000000 >=20 > ACPI Error: Method parse/execution failed [\_SB_.PCI0.SRSA] (Node > 004B7B50), AE_AML_BUFFER_LIMIT (20130418/psparse-632) ACPI Error: Method > parse/execution failed [\_SB_.PCI0.AUBA._SRS] (Node 004BEB50), > AE_AML_BUFFER_LIMIT (20130418/psparse-632) AcpiSetCurrentResources failed= : > AE_AML_BUFFER_LIMIT Evaluating _PRS > rscalc-0663 [04] RsGetListLength : Type 89, AmlLength 15 > InternalLength 28 > rslist-0217 [05] RsConvertAmlToResource: Type 89, AmlLength 15 > InternalLength 28 > rslist-0217 [05] RsConvertAmlToResource: Type 78, AmlLength 02 > InternalLength 0C >=20 > [00] Extended IRQ Resource > Type : ResourceConsumer > Triggering : Level > Polarity : ActiveLow > Sharing : Shared > Resource Source Index : 00 > Resource Source : [Not Specified] > Interrupt Count : 04 > Dword00 : 00000014 > Dword01 : 00000015 > Dword02 : 00000016 > Dword03 : 00000017 >=20 > [01] EndTag Resource > - >=20 >=20 >=20 > > -----Original Message----- > > From: Benjamin Lee [mailto:ben@b1c1l1.com] > > Sent: Friday, April 19, 2013 5:22 PM > > To: Moore, Robert > > Cc: John Baldwin; freebsd-acpi@freebsd.org > > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA IRQ > > 20 in legacy IRQ resource type) > > > > On Sat, 20 Apr 2013 00:09:55 +0000, "Moore, Robert" > > wrote: > > > Can you send the actual binary DSDT or the ASCII acpidump (not > > > disassembled) > > > > I missed this earlier, but I just noticed _OS and _OSI checks for > Windows. > > I'll need to do some testing with hw.acpi.osname. > > > > Here is the binary DSDT: > > > > http://www.b1c1l1.com/media/debug/20130419-nvidia.dsdt > > > > > > > > > > > > -----Original Message----- > > > > From: Benjamin Lee [mailto:ben@b1c1l1.com] > > > > Sent: Friday, April 19, 2013 4:35 PM > > > > To: Moore, Robert > > > > Cc: John Baldwin; freebsd-acpi@freebsd.org > > > > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put non-ISA > > > > IRQ 20 in legacy IRQ resource type) > > > > > > > > On Fri, 19 Apr 2013 23:00:07 +0000, "Moore, Robert" > > > > wrote: > > > > > No, the length must be set in all descriptors, end tag included. > > > > > > > > Do you have any pointers on how I can fix my ASL? Where do I find > > > > the end tags and what should I set the lengths to? > > > > > > > > Here is the output from acpidump -dt: > > > > http://www.b1c1l1.com/media/debug/20130418-nvidia.asl.gz > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- > > > > > > acpi@freebsd.org] On Behalf Of Benjamin Lee > > > > > > Sent: Friday, April 19, 2013 3:51 PM > > > > > > To: John Baldwin > > > > > > Cc: freebsd-acpi@freebsd.org > > > > > > Subject: Re: panic: acpi_pci_link_srs_from_crs: can't put > > > > > > non-ISA IRQ 20 in legacy IRQ resource type) > > > > > > > > > > > > On Fri, 19 Apr 2013 15:21:10 -0700, Benjamin Lee > > > > > > > > > > wrote: > > > > > > > On Fri, 19 Apr 2013 17:26:31 -0400, John Baldwin > > > > > > > > > > > > > wrote: > > > > > > > > On Friday, April 19, 2013 4:18:49 pm Benjamin Lee wrote: > > > > > > > > > On Fri, 19 Apr 2013 11:31:49 -0400, John Baldwin > > > > > > > > > > > > > > > wrote: > > > > > > > > > > On Thursday, April 18, 2013 3:49:40 pm Benjamin Lee > wrote: > > > > > > > > > > > I have a system that panics on boot with 10-CURRENT > > > > > > > > > > > and boots with many ACPI error messages and > > > > > > > > > > > non-functional devices with > > > > > > 9.1-RELEASE. > > > > > > > > > > > > > > > > > > > > > > Motherboard is Foxconn C51XEM2AA (NVIDIA nForce 590) > > > > > > > > > > > desktop > > > > > > board. > > > > > > > > > [...] > > > > > > > > > > > Even though 9.1-RELEASE boots successfully, devices > > > > > > > > > > > such as the ehci USB controller and SATA controller > > > > > > > > > > > do > > not work. > > > > > > > > > > > > > > > > > > > > Ugh, your BIOS does unexpected things. It uses a _CRS > > > > > > > > > > for these pci link devices that uses a "short" IRQ > > > > > > > > > > resource, but uses an extended IRQ > > > > > > > > resource in > > > > > > > > > > _PRS (and expects an extended one in _SRS). We use > > > > > > > > > > _CRS as a template for > > > > > > > > the > > > > > > > > > > resource to build. > > > > > > > > > > > > > > > > > > > > Try this patch. It's a bit hackish, but it forces us > > > > > > > > > > to not use _CRS as a template if _CRS uses a "short" > > > > > > > > > > IRQ resource, but the link supports non- > > > > > > > > ISA > > > > > > > > > > IRQs. > > > > > > > > > [...] > > > > > > > > > > > > > > > > > > Thanks, that fixed the panic and the system boots. Now > > > > > > > > > it is complaining about AE_AML_BAD_RESOURCE_LENGTH and > > > > > > > > > still unable to route IRQs, but it definitely looks > > > > > > > > > better than the ACPI parsing > > > > > > errors in 9: > > > > > > > > > > > > > > > > > > pcib0: allocated type 3 (0xdffff000-0xdfffffff) for rid > > > > > > > > > 10 of > > > > > > > > > pci0:0:10:0 > > > > > > > > > pcib0: matched entry for 0.10.INTA (src > > > > > > > > > \_SB_.PCI0.AUBA:0) > > > > > > > > > pci_link26: Picked IRQ 20 with weight 0 > > > > > > > > > pci_link26: Unable to route IRQs: > > > > > > > > > AE_AML_BAD_RESOURCE_LENGTH > > > > > > > > > > > > > > > > > > Full boot -v output: > > > > > > > > > http://www.b1c1l1.com/media/debug/20130419-10-patched- > > > > > > > > boot.txt.gz > > > > > > > > > > > > > > > > Can you add some printfs to the places that return the > > > > > > > > AE_AML_BAD_RESOURCE_LENGTH to see which one is being > > triggered? > > > > > > > > (Just look for that constant in sys/contrib/dev/acpica to > > > > > > > > find the possible places.) > > > > > > > > > > > > > > Is there a macro for dumping information about Resource or > > > > > > > Resource->Data? Here's what I have for now at > > > > > > > sys/contrib/dev/acpica/resources/rscalc.c line 237: > > > > > > > > > > > > > > pcib0: matched entry for 0.10.INTA (src \_SB_.PCI0.AUBA:0) > > > > > > > pci_link26: Picked IRQ 20 with weight 0 > > > > > > > rscalc.c:237 > > > > > > > Resource->Type: 7 > > > > > > > Resource->Length: 0 > > > > > > > pci_link26: Unable to route IRQs: AE_AML_BAD_RESOURCE_LENGTH > > > > > > > > > > > > > > All of the errors are from there and look identical (Type 7, > > > > > > > Length > > > > 0). > > > > > > > Type 7 appears to be ACPI_RESOURCE_TYPE_END_TAG. > > > > > > > > > > > > This hack fixes everything (now the SATA controller works). > > > > > > It seems that the Resource->Length check might not be > > > > > > necessary for ACPI_RESOURCE_TYPE_END_TAG. > > > > > > > > > > > > blee@genesis /usr/src/sys/contrib/dev/acpica $ svn diff > > > > > > Index: components/resources/rscalc.c > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > > --- components/resources/rscalc.c (revision 249624) > > > > > > +++ components/resources/rscalc.c (working copy) > > > > > > @@ -234,6 +234,15 @@ > > > > > > > > > > > > if (!Resource->Length) > > > > > > { > > > > > > + if (Resource->Type =3D=3D ACPI_RESOURCE_TYPE_END_T= AG) { > > > > > > + TotalSize =3D AcpiGbl_AmlResourceSizes > > > > > > + [Resource- > > > > >Type]; > > > > > > + printf("TotalSize: %u\n", TotalSize); > > > > > > + if (TotalSize !=3D 0) { > > > > > > + printf("ACPI_RESOURCE_TYPE_END_TAG > hack\n"); > > > > > > + *SizeNeeded =3D AmlSizeNeeded + TotalSize; > > > > > > + return_ACPI_STATUS (AE_OK); > > > > > > + } > > > > > > + } > > > > > > return_ACPI_STATUS (AE_AML_BAD_RESOURCE_LENGTH); > > > > > > } > > > > > > > > > > > > Index: components/resources/rslist.c > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > > --- components/resources/rslist.c (revision 249624) > > > > > > +++ components/resources/rslist.c (working copy) > > > > > > @@ -203,6 +203,11 @@ > > > > > > > > > > > > if (!Resource->Length) > > > > > > { > > > > > > + if (Resource->Type =3D=3D ACPI_RESOURCE_TYPE_END_T= AG) { > > > > > > + printf("ACPI_RESOURCE_TYPE_END_TAG hack 2\n"); > > > > > > + return_ACPI_STATUS (AE_OK); > > > > > > + } > > > > > > + > > > > > > ACPI_ERROR ((AE_INFO, > > > > > > "Invalid zero length descriptor in resource > > > > list\n")); > > > > > > return_ACPI_STATUS (AE_AML_BAD_RESOURCE_LENGTH); > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Benjamin Lee > > > > > > http://www.b1c1l1.com/ > > > > > > > > > > > > > > > > -- > > > > Benjamin Lee > > > > http://www.b1c1l1.com/ > > > > > > > > -- > > Benjamin Lee > > http://www.b1c1l1.com/