From nobody Fri Oct 7 19:30:44 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mkdh63npXz4dhPq; Fri, 7 Oct 2022 19:30:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mkdh63MlBz3TpN; Fri, 7 Oct 2022 19:30:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665171046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Glqi2obURFB+be14luy+VngVYbRLaNPC3ohNvUH/XcM=; b=rwon2uVDOYiqu3b+ZbXA+hhglqHEr1P/FwgeTaSY5wYdDSj3jP1hm39k6YxQTXYIn3buJO Ed+8gGvidbyDSsmEKchX3SbjsMJVvzA7FbpwI88Ih3e10e+q29eJ7EWIhr5Q8IiaM4oPsR aeWagjMlWBpZ/k7d4ESX6T0Zx3Qf5eA68iHqv90Z5REhWLNwwnWXqaW/8s3lBbPKxKsvxL A0gyFATGsnbTAv7OHomtlnwFhmJrFd3Z049OnZtFfaQ88b8h12fYhqyW22F4W8U6pl81G8 wy6TgjnkpVZ5avKSFtejY+3/eZfLotnyOP/xXVV4pWioa1C/qBSYSU5vntbTRA== Received: from [IPV6:2601:648:8684:ad0:94d8:ad3b:a95b:e90a] (unknown [IPv6:2601:648:8684:ad0:94d8:ad3b:a95b:e90a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Mkdh53z9szfCr; Fri, 7 Oct 2022 19:30:45 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <10a7f04e-5684-5434-d74b-ec80d6c1eea0@FreeBSD.org> Date: Fri, 7 Oct 2022 12:30:44 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: git: 62d42655bca1 - main - usb(4): Substitute "unsigned int" using the equivalent and shorter "unsigned" keyword. Content-Language: en-US To: "Piotr P. Stefaniak" , Hans Petter Selasky Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202210071141.297BfcjN071407@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1665171046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Glqi2obURFB+be14luy+VngVYbRLaNPC3ohNvUH/XcM=; b=mhmCirQhm71Ef6rTURDo56mkC6bJbdI3TRFn2LmSO+4b4+iluwxBZZak3ptt4jHh4QjU/u z2suxlG/xtiH5KF80c68z/y7IEf/67bADCm/3wu02VWN6mNqm/LKpbXBqs7hYnbJVnFDB4 Up3+JtUCuXR5l7jnRBlXFjyq76ji9CYLER5VYcl+N0IPr3q3g1PeVOsMCrJKdDiWyaDWK+ dzXQnaPwPEpDdnDc4N3edf6/miQ+3UkZ68mhoNyYskSHFWtH06CDzYsXKi0XJMb7xmBlJj 9ObqprSg/0NfY/UaGrBJgZbT00oNle3iR4TaPWCb334Yl75wDCLatDEle2zdKw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1665171046; a=rsa-sha256; cv=none; b=gNSpNTcFWRCCsHFGwrDWyjXM+Fh8iif64DjuDFGL1rKDDM3TH9494WckIuYkynKyy6qG0v JMQQgOfCYwE1OiEz/vpOCB6XXms5TZMMK5CjRy5L3KuUz2einnSPB4b7SyOVjrD2PwFS98 hhaZwH4yuOMrkL7/z5ngQvRnZwb2usMBDU2+3XiTq+NYwWZ5GooglzPyZAM+5aNnkwngMd CoxHvA4yM3TgqJ7y6eb5bu5PAvAbU2WujZQjYOr9yNuzr2DP/OxRJB4Dhhe8O2X/uFjr3C cV0UlXU8HY+loKj8jx839JGaJpmP5N20YsNvCm5z8yrraG0+he7uXnK43qdUhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 10/7/22 7:43 AM, Piotr P. Stefaniak wrote: > On 2022-10-07 16:21:01, Hans Petter Selasky wrote: > >> Would uint32_t be more clear? > > I don't disagree with the style change to the point that I demand it be > corrected, please keep it the way it is now to avoid more churn. Agreed. > I just opposed the more general idea that this is an improvement. I say > it's debatable, at least until we have style.9 rule one way or the other. Yeah, I think it's a regression to be honest. None of the other unsigned base C types (unsigned short, unsigned long, etc.) have these short cuts in the language. I consider it bit of an odd anachronism. If you really want to use a shorter spelling of "unsigned int" in the tree, I think "u_int" is a better choice and more typical in FreeBSD. -- John Baldwin