From owner-svn-src-head@freebsd.org Wed Aug 26 19:21:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C0CE83B91F2; Wed, 26 Aug 2020 19:21:46 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BcG224m9wz4WJ0; Wed, 26 Aug 2020 19:21:46 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8201622EEB; Wed, 26 Aug 2020 19:21:46 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 53E6127C0054; Wed, 26 Aug 2020 15:21:46 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute4.internal (MEProxy); Wed, 26 Aug 2020 15:21:46 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddvvddgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculddutddmnecujfgurhepofgfggfkjghffffhvffutgesthdtredt reerjeenucfhrhhomhepfdeurhgrnhguohhnuceuvghrghhrvghnfdcuoegsughrrghgoh hnsefhrhgvvgeuufffrdhorhhgqeenucggtffrrghtthgvrhhnpeehieeikeekffekleek leegtefgledttefghfduteeikeevfedvhfeggfffudejgfenucffohhmrghinhepfhhrvg gvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpegsughrrghgohhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqd dutdegvdefheekieegqddukedutdekheduqdgsughrrghgohhnpeephfhrvggvuefuffdr ohhrghesihhmrghprdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id C4E11C200A5; Wed, 26 Aug 2020 15:21:45 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-232-g4bdb081-fm-20200825.002-g4bdb081a Mime-Version: 1.0 Message-Id: In-Reply-To: <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> References: <202008260237.07Q2bhwF045988@repo.freebsd.org> <7e0abc1a-a397-46c3-b283-2c1ab21a9c4d@www.fastmail.com> <2534D2E5-2974-4067-8B9C-53EE3E8C6A68@freebsd.org> Date: Wed, 26 Aug 2020 14:21:24 -0500 From: "Brandon Bergren" To: "Jessica Clarke" Cc: "Alan Somers" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: =?UTF-8?Q?Re:_svn_commit:_r364799_-_in_head:_share/man/man9_sys/crypto/c?= =?UTF-8?Q?cp_sys/dev/cxgbe/crypto_sys/dev/sec_sys/kern_sys/opencrypto?= Content-Type: text/plain X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 19:21:46 -0000 On Wed, Aug 26, 2020, at 2:19 PM, Jessica Clarke wrote: > On 26 Aug 2020, at 20:16, Brandon Bergren wrote: > > On Tue, Aug 25, 2020, at 9:37 PM, Alan Somers wrote: > >> Author: asomers > >> Date: Wed Aug 26 02:37:42 2020 > >> New Revision: 364799 > >> URL: https://svnweb.freebsd.org/changeset/base/364799 > >> > >> Modified: head/sys/dev/sec/sec.c > >> ============================================================================== > >> --- head/sys/dev/sec/sec.c Wed Aug 26 02:13:27 2020 (r364798) > >> +++ head/sys/dev/sec/sec.c Wed Aug 26 02:37:42 2020 (r364799) > >> @@ -851,6 +851,9 @@ sec_desc_map_dma(struct sec_softc *sc, struct sec_dma_ > >> case CRYPTO_BUF_MBUF: > >> size = m_length(crp->crp_buf.cb_mbuf, NULL); > >> break; > >> + case CRYPTO_BUF_VMPAGE: > >> + size = PAGE_SIZE - cb->cb_vm_page_offset; > >> + break; > >> default: > >> return (EINVAL); > >> } > > > > Uh, where is cb coming from? Shouldn't this be using crp->crp_buf.cb_vm_page_offset? This is causing a build failure on powerpc and powerpcspe. I don't see why other platforms aren't also erroring out here. > > Because it's PowerPC-specific: > > sys/conf/files.powerpc:dev/sec/sec.c optional sec mpc85xx > > Jess > > No, I mean literally. What scope is cb coming from? It's not a variable that is in scope for that function as far as I can tell. -- Brandon Bergren bdragon@FreeBSD.org