From nobody Wed May 1 17:19:09 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VV3hF6cTbz5JkZ9; Wed, 1 May 2024 17:19:09 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VV3hF5t2Cz4Nt7; Wed, 1 May 2024 17:19:09 +0000 (UTC) (envelope-from gnn@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714583949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DU60epuNAHS54R31chiUYb3HrQxaD+xro1c29GAY7lU=; b=cZC3v1hTTQyPDsnh4KGiWlX7ljrvOY+/Sgk4MDZaCxcBmF1LvrMuez5AO79yMUMjpUJed2 +zY8BhGgp1VsZsB6QIwOK1p59fzOAtnB8/nYH+UWDNGjY8gmQkm4kGUxvYCULG9hgkNHCT Pex0jvzROc6A1U9gKz1qNaETTVXohfUaqolI/DJTCu7Yq2/fERfMsC7AjrFCJDlabugwk7 6ECPTzWV9ynHDN3nGFYK6J+BX8uwEZTjvgPrpipixmzXC9Jsh6EVhtl4RrLr7jTPbA3v8p +b+9yveIDm3WwTMYu18aODKdkejCMwDUaTFPe/wlhZoy5nfAfaOpfS+oe2Jq6w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714583949; a=rsa-sha256; cv=none; b=wqrccm679CC0h/LyeuHaA1tB+KbIu0KADlnu+0i4vBW9+jvdohj4YryzHG/6ocY0o77jfu /WsYiIITHJ5soJnKl7QahM7HV4HRPXVw+PcENZ0AN5sHlxjAHhtbQpoyLOARN3YUfAwpVu uumHyjyKuNQ2sOZodLcu67GVlEZFNzEXK7El3xNarvX4HV52TePd6RNwuD3/s+LMGd1kxW uIDB9SKkq+onGWfOBgM6KQ/mi99s1NU+AWXApYfwJciWakbOgXeUAs8WpvQI3Jmq1c4pfj zdpMgGC5t5CQ/HSH9oXltifLtNRCiBBWPfOgbS00wiwE62dV4L6slv6BZDMqDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714583949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DU60epuNAHS54R31chiUYb3HrQxaD+xro1c29GAY7lU=; b=SzxVJDAl47r2s/vbIas6AMSODGYGcwRv+XmL9EP5MfoleJsNzvNB0c0gue8ANW+wg7spJP WaRDL5XetSgerUxUDX8O/hUDhO27Ccs6kfE55sgxG05cf6axvci7EqlRdPGqFUOnvuo1Cb PmESKdc2zIJPoIeXMQ32XW4Yx+KCfjkiPqiuqS3MgdJegI/jVw2NUQJ9Ar0Q6Cuzf/Gch+ n2vLyj5LUYJC7PQ9mw3N588aq6hXjWTfD31zz1nAGcQVq0jZd43ecimWBSFRSI/78FZ1Qw MVUXXTCli8iVd3/vZSWuf4JMzfLDBbkycZTxJeK7/FQz8fbA+HAOed0eE+oXEQ== Received: from [192.168.68.1] (syn-074-071-194-206.res.spectrum.com [74.71.194.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gnn) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VV3hF4jMgzbZN; Wed, 1 May 2024 17:19:09 +0000 (UTC) (envelope-from gnn@freebsd.org) From: gnn To: Jessica Clarke Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: e60ca52b72e5 - main - Out of tree modules should be built with DTrace by default. Date: Wed, 01 May 2024 13:19:09 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org> References: <202405011701.441H17Wf008095@gitrepo.freebsd.org> <909C5B39-B3C0-4111-BE59-4F9B4576C4C8@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 1 May 2024, at 13:08, Jessica Clarke wrote: > On 1 May 2024, at 18:01, George V. Neville-Neil wrote= : >> >> The branch main has been updated by gnn: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3De60ca52b72e518f8394615b= dad9cd9c85764caa2 >> >> commit e60ca52b72e518f8394615bdad9cd9c85764caa2 >> Author: George V. Neville-Neil >> AuthorDate: 2024-05-01 17:00:52 +0000 >> Commit: George V. Neville-Neil >> CommitDate: 2024-05-01 17:00:52 +0000 >> >> Out of tree modules should be built with DTrace by default. >> --- >> share/examples/modules/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/share/examples/modules/Makefile b/share/examples/modules/= Makefile >> index 0f0a2fb01e8a..bc7f6f6a57ac 100644 >> --- a/share/examples/modules/Makefile >> +++ b/share/examples/modules/Makefile >> @@ -4,3 +4,5 @@ KMOD=3D skel >> SRCS=3D skel.c >> >> .include >> + >> +CFLAGS:=3D ${CFLAGS:N -DKDTRACE_HOOKS} > > I believe this is a no-op in practice, and definitely doesn=E2=80=99t d= o what > you want? :N is "select all words that don=E2=80=99t match the given pa= ttern", > so this expands to CFLAGS with any instances of " -DKDTRACE_HOOKS" > removed. But that=E2=80=99s a no-op, because the space won=E2=80=99t be= present in the > word itself unless you start quoting things, and it then wouldn=E2=80=99= t be a > valid compiler flag. > Interesting because it built with the hooks out of tree. Let me clean it= up anyways. Thanks, George