From owner-svn-src-head@freebsd.org  Wed Nov  1 18:54:31 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1744AE625A4;
 Wed,  1 Nov 2017 18:54:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E92807DC3D;
 Wed,  1 Nov 2017 18:54:30 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-3.local (unknown
 [IPv6:2601:648:8500:5fb:c09d:da52:73d2:8219])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 2758310A7DB;
 Wed,  1 Nov 2017 14:54:23 -0400 (EDT)
Subject: Re: svn commit: r325166 - head/sys/net
To: Stephen Hurd <shurd@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201710302108.v9UL8CMP071651@repo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <ed2c3fb2-1b68-06b9-a9df-e9d9e883fac2@FreeBSD.org>
Date: Wed, 1 Nov 2017 11:54:21 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <201710302108.v9UL8CMP071651@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Wed, 01 Nov 2017 14:54:23 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Nov 2017 18:54:31 -0000

On 10/30/17 9:08 PM, Stephen Hurd wrote:
> Author: shurd
> Date: Mon Oct 30 21:08:12 2017
> New Revision: 325166
> URL: https://svnweb.freebsd.org/changeset/base/325166
> 
> Log:
>   Avoid enabling MSI-X if MSI-X is disabled globally
>   
>   It was reported on the community call that with
>   hw.pci.enable_msix=0, iflib would enable MSI-X on the device and attempt
>   to use it, which caused issues. Test the sysctl explicitly and do not
>   enable MSI-X if it's disabled globally.

There are also various blacklists you should probably be honoring.  If
you just use the existing APIs (pci_*_msix()) that should all happen
transparently however.  Also, the 'enable_msi=0' tunable disables both MSI
and MSI-X (again, if you used the existing API that is already handled)

-- 
John Baldwin