From owner-svn-src-all@freebsd.org Tue Aug 23 22:18:51 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72853BC4796; Tue, 23 Aug 2016 22:18:51 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pa0-x22d.google.com (mail-pa0-x22d.google.com [IPv6:2607:f8b0:400e:c03::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4259B1EEC; Tue, 23 Aug 2016 22:18:51 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pa0-x22d.google.com with SMTP id hb8so33375605pac.2; Tue, 23 Aug 2016 15:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=r2Ud/vEkpSPX5EBiB0nOQpVy9XK7KxwBhXBCtre7L1M=; b=UlLplzriZZ6tGfx3vBVYsJkMf8e0SsidOv5R+YgymyT3lNdfNZKL+q3kml119L6HHl gpJGfgXDlL/ncATUzz70h1RXopXFu9iiYYLptZa1Z3zhNCIZcgwwTF+/0mj9F2wGlCMx gMPtoWoSgcna6nNHLHuursVWlDXAMDYKA2R/SXwb3BzbaXiCHgK0/tHcNi13Mt3m41tK DaF9bnEYesvR2Q8nkO1bEMOSQqnWiQRTEnQAEV7bnlnVOMGuk9dCGXcqSXzi0qcXg36d 3oKMdlF3UqZVL5fEQaasGdRGd+L4xQXIuGMLxLiNyQdrmc2f+/JYwIaRo+m7d/zkyoRj Gl9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=r2Ud/vEkpSPX5EBiB0nOQpVy9XK7KxwBhXBCtre7L1M=; b=j1gQW8HCAbRZFjoWYY3DjyWqII1fcCxO2w1KyAiXK7kXDT7ZiywtXbgG+qp/UPxgEU APaVBzkrP5LglFBBIq9ZvvWACvIsW8FLqyo+YHLROtTXlzgpH9N/nKDGi6ILaSTnwR5w MsLhMs0g5I7hW2+GsgzXxQ3yBieX52xdWmQooNb57DJFPw1D4if58JaDQipn96DHa+II UyQebavU2kNR7AVXP5o4OSCaZpsER1qG2jHt9bucyawvwpxPS62FC5PYQ+re2RSzlY1T MiwnVMCAowEvNCn/44XTfV2QFLBQ8bd/wEbvMOFXN7FGWzZAgBaQAUQbUSCeeY26j0JY kfuA== X-Gm-Message-State: AEkoouueM62Ctz6pGK/bG/aWIUHF1eh7/E/hOMuyjfrpvxcgIRn6CaBfj7VCKEoDuY233A== X-Received: by 10.66.86.170 with SMTP id q10mr56740385paz.105.1471990730462; Tue, 23 Aug 2016 15:18:50 -0700 (PDT) Received: from [10.192.166.0] (stargate.chelsio.com. [12.32.117.8]) by smtp.googlemail.com with ESMTPSA id ah5sm8075591pad.30.2016.08.23.15.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2016 15:18:49 -0700 (PDT) Sender: Navdeep Parhar Subject: Re: svn commit: r304704 - in stable/11/sys: conf kern net sys To: Stephen Hurd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <201608232121.u7NLLvDq072781@repo.freebsd.org> From: Navdeep Parhar Message-ID: <7723623e-67cf-0a0a-6cba-4a3f5bdb8f16@FreeBSD.org> Date: Tue, 23 Aug 2016 15:18:48 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <201608232121.u7NLLvDq072781@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2016 22:18:51 -0000 On 08/23/2016 14:21, Stephen Hurd wrote: > Author: shurd (ports committer) > Date: Tue Aug 23 21:21:56 2016 > New Revision: 304704 > URL: https://svnweb.freebsd.org/changeset/base/304704 > > Log: > MFC r304021: Update iflib to support more NIC designs > > - Move group task queue into kern/subr_gtaskqueue.c > - Change intr_enable to return an int so it can be detected if it's not > implemented > - Allow different TX/RX queues per set to be different sizes > - Don't split up TX mbufs before transmit > - Allow a completion queue for TX as well as RX > - Pass the RX budget to isc_rxd_available() to allow an earlier return > and avoid multiple calls > > Approved by: sbruno > > Added: > stable/11/sys/kern/subr_gtaskqueue.c > - copied unchanged from r304021, head/sys/kern/subr_gtaskqueue.c > stable/11/sys/sys/gtaskqueue.h > - copied unchanged from r304021, head/sys/sys/gtaskqueue.h > Modified: > stable/11/sys/conf/files > stable/11/sys/kern/subr_taskqueue.c > stable/11/sys/net/ifdi_if.m > stable/11/sys/net/iflib.c > stable/11/sys/net/iflib.h (I'm assuming that you do not plan to merge this to releng/11.0.) It looks like the changes to iflib.h will break any external NIC driver written/compiled against the iflib.h in 11.0. Is iflib considered part of the KPI/KBI in FreeBSD 11 or is it for in-tree use only with no interface guarantees? If it's the latter then why do we even have iflib in 11.0 given that no in-tree driver in 11.0 uses it? Regards, Navdeep > stable/11/sys/sys/_task.h > stable/11/sys/sys/taskqueue.h > Directory Properties: > stable/11/ (props changed) > > ...