From owner-dev-commits-src-main@freebsd.org Fri Feb 26 18:16:51 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 32381549FA4; Fri, 26 Feb 2021 18:16:51 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnHtB3G3vz4gRd; Fri, 26 Feb 2021 18:16:50 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1614363402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M2ln7IYckZctsz4NLtTcC+4Cd7IhLlnOSkqivYBxxwI=; b=beYrIpYF02dKgnZCmBPCRf/aV5+4t9EqL+I2sVWAl+ZiNVcK6ytngwY9dLpHPngLQV2qoB MwHCXOGvDOaWLFaD6rZLYEOCL6cjSMCqT/43VDF5XjO2WeRhMB1cIkxJN8OVcbHKAZ3qNf U6XOSxPi3HImdp3o06cOdyfN4jgGK6s= Received: from skull.home.blih.net (lfbn-idf2-1-644-4.w86-247.abo.wanadoo.fr [86.247.100.4]) by mx.blih.net (OpenSMTPD) with ESMTPSA id e2bd1665 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 26 Feb 2021 18:16:42 +0000 (UTC) Date: Fri, 26 Feb 2021 19:16:38 +0100 From: Emmanuel Vadot To: Baptiste Daroussin Cc: rgrimes@freebsd.org, Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database Message-Id: <20210226191638.84c83ef81207217de2359a96@bidouilliste.com> In-Reply-To: <20210226173629.2sc6wlaasxjep3le@aniel.nours.eu> References: <202102261420.11QEKJoX006569@slippy.cwsent.com> <202102261730.11QHUh8n031156@gndrsh.dnsmgr.net> <20210226173629.2sc6wlaasxjep3le@aniel.nours.eu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DnHtB3G3vz4gRd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 18:16:51 -0000 On Fri, 26 Feb 2021 18:36:29 +0100 Baptiste Daroussin wrote: > On Fri, Feb 26, 2021 at 09:30:43AM -0800, Rodney W. Grimes wrote: > > > In message <202102251327.11PDR4eC083842@gitrepo.freebsd.org>, Baptiste > > > Daroussi > > > n writes: > > > > The branch main has been updated by bapt: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae > > > > 14376f80 > > > > > > > > commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > > > > Author: Baptiste Daroussin > > > > AuthorDate: 2021-02-23 16:17:32 +0000 > > > > Commit: Baptiste Daroussin > > > > CommitDate: 2021-02-25 13:25:32 +0000 > > > > > > > > terminfo: add terminfo database > > > > > > > > Tested by: manu, jbeich > > > > --- > > > > share/Makefile | 1 + > > > > share/terminfo/Makefile | 34 ++++++++++++++++++++++++++++++++++ > > > > 2 files changed, 35 insertions(+) > > > > > > > > diff --git a/share/Makefile b/share/Makefile > > > > index c4e12b05f7db..d6854b230ae5 100644 > > > > --- a/share/Makefile > > > > +++ b/share/Makefile > > > > @@ -26,6 +26,7 @@ SUBDIR= ${_colldef} \ > > > > ${_syscons} \ > > > > tabset \ > > > > termcap \ > > > > + terminfo \ > > > > ${_timedef} \ > > > > ${_vt} \ > > > > ${_zoneinfo} > > > > diff --git a/share/terminfo/Makefile b/share/terminfo/Makefile > > > > new file mode 100644 > > > > index 000000000000..7bb11f3fdf24 > > > > --- /dev/null > > > > +++ b/share/terminfo/Makefile > > > > @@ -0,0 +1,34 @@ > > > > +PACKAGE= runtime > > > > + > > > > +.PATH: ${SRCTOP}/contrib/ncurses/misc > > > > +TINFOBUILDDIR= ${.OBJDIR}/builddir > > > > +CLEANDIRS+= builddir > > > > + > > > > +.include > > > > + > > > > +.if !defined(_SKIP_BUILD) > > > > +all: terminfo > > > > +.endif > > > > +META_TARGETS+= terminfo install-terminfo > > > > + > > > > +terminfo: terminfo.src > > > > + mkdir -p ${TINFOBUILDDIR} > > > > + ${TIC_CMD} -x -o ${TINFOBUILDDIR} ${.ALLSRC} > > > > + > > > > +.if make(*install*) > > > > +TINFOS!= cd ${TINFOBUILDDIR} && find * -type f | LC_ALL=C sort > > > > +TINFOSDIRS= ${TINFOS:C/(.).*/\1/g:O:u} > > > > +.endif > > > > + > > > > +beforeinstall: install-terminfo > > > > +install-terminfo: > > > > + mkdir -p ${DESTDIR}/usr/share/terminfo > > > > + cd ${DESTDIR}/usr/share/terminfo; mkdir -p ${TINFOSDIRS} > > > > +.for f in ${TINFOS} > > > > + ${INSTALL} ${TAG_ARGS} \ > > > > + -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ > > > > + ${TINFOBUILDDIR}/${f} ${DESTDIR}/usr/share/terminfo/${f} > > > > +.endfor > > > > + > > > > +.include > > > > + > > > > > > > > > > I think this had some unintended consequences, a POLA violation that should > > > be documented. Our termcap didn't support alternate screen buffers while > > > terminfo does. Termcap did through t_te and t_ti but we didn't use them. > > > Terminfo as delivered from the ncurses factory does supply rmcup and smcup; > > > our fullscreen apps such as nvi and top see them and use the alternate > > > screen buffer. > > > > > > The use of the alternate screen buffer is one of the things I hate about > > > Linux. After running vi or top I expect the output to remain on the screen > > > so I can use some bit of information in my next command. We now have this > > > behaviour too. > > > > Oh, I so hate that mis-feature of Linux, please please tell me there is > > a simple knob to turn this off? I believe LESS also does this kind > > of stuff, or atleast "man" on linux does, and that pees me off to no > > end when I quit the man page and what I wanted is no longer on the screen. > > > > > No this is not and I clear have 0 intention to have a complex patch on top of > the linux terminfo which would prefer easy sync in the futur. > > We can document how to use a definition which does not have the feature you do > not like. > > Best, > Bapt Tips from jbeich@ via irc/gitter : xterm: Set XTerm.VT100.titeInhibit: true screen: altscreen off tmux: et -g alternate-screen off generic ncurses: export TERMCAP="${TERM}:ti@:te@:tc=${TERM}" Feel free to add this to any documentation part you feel it belongs too (even if it is, I'm almost sure, documented in each programs man/help pages). -- Emmanuel Vadot