From owner-p4-projects  Sat Jul 13 15:50:56 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5D89B37B401; Sat, 13 Jul 2002 15:50:51 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 19FCF37B400
	for <perforce@freebsd.org>; Sat, 13 Jul 2002 15:50:51 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CC2BE43E31
	for <perforce@freebsd.org>; Sat, 13 Jul 2002 15:50:50 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6DMooJU070322
	for <perforce@freebsd.org>; Sat, 13 Jul 2002 15:50:50 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6DMoohq070319
	for perforce@freebsd.org; Sat, 13 Jul 2002 15:50:50 -0700 (PDT)
Date: Sat, 13 Jul 2002 15:50:50 -0700 (PDT)
Message-Id: <200207132250.g6DMoohq070319@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 14198 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14198

Change 14198 by rwatson@rwatson_paprika on 2002/07/13 15:50:10

	Add an XXX comment since releasing the vnode lock here will
	result in nasty race conditions.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/sebsd/sebsd.c#12 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/sebsd/sebsd.c#12 (text+ko) ====

@@ -415,6 +415,9 @@
 		char *freepath = NULL;
 		struct vattr va;
 
+		/*
+		 * XXX Releasing the vnode lock here is a very bad idea.
+		 */
 		VOP_GETATTR(vp, &va, curthread->td_ucred, curthread);
 		VOP_UNLOCK(vp, 0, curthread);
 		vn_fullpath(curthread, vp->v_dd, vp, &fullpath, &freepath);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message