From owner-svn-src-all@freebsd.org Thu Sep 17 09:37:40 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A84399CE52B; Thu, 17 Sep 2015 09:37:40 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B2061977; Thu, 17 Sep 2015 09:37:39 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 835CA1FE023; Thu, 17 Sep 2015 11:37:36 +0200 (CEST) Subject: Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys To: David Chisnall References: <201509141052.t8EAqRWf008293@repo.freebsd.org> <20150916220559.GS1023@FreeBSD.org> <55FA69BD.10507@selasky.org> <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Hans Petter Selasky Message-ID: <55FA8A3F.4000005@selasky.org> Date: Thu, 17 Sep 2015 11:39:11 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <0952027A-5276-487D-99B8-74747B0EEF5D@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2015 09:37:40 -0000 On 09/17/15 11:07, David Chisnall wrote: > On 17 Sep 2015, at 08:20, Hans Petter Selasky wrote: >> >> On 09/17/15 00:05, Gleb Smirnoff wrote: >>> Weren't you explicitly asked not to touch this system without a proper >>> review and discussion? >> >> Adding a new function is not touching code. > > Adding a new interface to an existing core subsystem is most definitely touching the system. I would expect *anyone* making a change like this to have both the design and code reviewed for sanity checking. > For someone who has already been required to have explicit review of any changes to the subsystem to skip this step shows a flagrant disregard for the project’s policies and best practices. David, My patch is _not_ touching the existing callout system. It's touching the callout API. Maybe my understanding of touching is different than yours. You can voice your conserns in phabricator please, isn't that why we have Phabricator? https://reviews.freebsd.org/D3521 The differential review has been out for 14 days with relevant people like rss on the reviewers list, and no conserns were raised. Only manual page comments from wblock, and those were addressed. I will refer to a well known saying, that whoever tier agree. It is a bit late to shout now. David, I think phabricator allows filtering so that all commits which touch sys/kern gets your subscription. At least wblock was automatically subscribed because of updating some manual pages. I think that's the way to go. Let's end this discussion here and move it somewhere else. --HPS