Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Apr 2023 19:06:19 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: e6b5fb28a560 - main - math/trlan: fix build for base system WITH_LLVM_BINUTILS
Message-ID:  <202304241906.33OJ6JRB014855@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e6b5fb28a560cda9f101a2c2fc55ef70f00a2179

commit e6b5fb28a560cda9f101a2c2fc55ef70f00a2179
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-04-21 20:21:16 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-04-24 19:05:08 +0000

    math/trlan: fix build for base system WITH_LLVM_BINUTILS
    
    Use strip --strip-unneeded instead of strip -x.  strip -x strips all
    non-global symbols, but there are some non-global symbols referenced by
    relocations.  ELF Tool Chain strip and GNU strip silently retain those
    symbols, but LLVM strip is more strict and reports an error.
    
    PR:             270958
    Reviewed by:    jrm
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D39754
---
 math/trlan/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/math/trlan/Makefile b/math/trlan/Makefile
index 95896d36e1dc..50f208c37445 100644
--- a/math/trlan/Makefile
+++ b/math/trlan/Makefile
@@ -48,7 +48,7 @@ do-build:
 	@${ECHO_CMD} "Building static archive ..."
 	@cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} ${MAKE_ARGS} \
 		${ALL_TARGET}
-	@${STRIP_CMD} -x -o ${WRKDIR}/libtrlan.a ${WRKSRC}/libtrlan.a
+	@${STRIP_CMD} --strip-unneeded -o ${WRKDIR}/libtrlan.a ${WRKSRC}/libtrlan.a
 	@cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${_MAKE_JOBS} ${MAKE_ARGS} \
 		clean
 	@${ECHO_CMD} "Building shared library ..."



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202304241906.33OJ6JRB014855>