From owner-svn-ports-head@FreeBSD.ORG  Mon Jul 21 20:59:32 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E835537B;
 Mon, 21 Jul 2014 20:59:32 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D4DC2360;
 Mon, 21 Jul 2014 20:59:32 +0000 (UTC)
Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca
 [108.170.169.12])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 619D212B1D9;
 Mon, 21 Jul 2014 16:59:30 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: svn commit: r362484 - head/www/WebMagick
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <CAALwa8=Pi14WpoGLjg53-9a64q2Xa=tZopc=xBDi+-wrnBYOiA@mail.gmail.com>
Date: Mon, 21 Jul 2014 16:59:29 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <6400BBC7-4F40-45AC-8786-E452FECE386C@adamw.org>
References: <201407212053.s6LKru8U037225@svn.freebsd.org>
 <CAALwa8=Pi14WpoGLjg53-9a64q2Xa=tZopc=xBDi+-wrnBYOiA@mail.gmail.com>
To: Antoine Brodin <antoine@FreeBSD.org>
X-Mailer: Apple Mail (2.1878.6)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Adam Weinberger <adamw@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2014 20:59:33 -0000

On 21 Jul, 2014, at 16:57, Antoine Brodin <antoine@FreeBSD.org> wrote:

> On Mon, Jul 21, 2014 at 10:53 PM, Adam Weinberger <adamw@freebsd.org> =
wrote:
>> Author: adamw
>> Date: Mon Jul 21 20:53:56 2014
>> New Revision: 362484
>> URL: http://svnweb.freebsd.org/changeset/ports/362484
>> QAT: https://qat.redports.org/buildarchive/r362484/
>>=20
>> Log:
>>  As suggested by ache, actually check for the presence of =
Image/Magick.pm and only barf if it
>>  doesn't exist.
>>=20
>> Modified:
>>  head/www/WebMagick/Makefile
>>=20
>> Modified: head/www/WebMagick/Makefile
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/www/WebMagick/Makefile Mon Jul 21 20:51:34 2014        =
(r362483)
>> +++ head/www/WebMagick/Makefile Mon Jul 21 20:53:56 2014        =
(r362484)
>> @@ -38,12 +38,15 @@ X11_BUILD_DEPENDS=3D  xlsfonts:${PORTSDIR}/
>> X11_RUN_DEPENDS=3D       xlsfonts:${PORTSDIR}/x11-fonts/xlsfonts
>> X11_CONFIGURE_ENV_OFF=3D with_x=3Dno
>>=20
>> -pre-everything::
>> -       @${ECHO_CMD}
>> -       @${ECHO_CMD} ${PORTNAME} requires that ImageMagick be =
installed with the PERL option enabled.
>> -       @${ECHO_CMD}
>> +.include <bsd.port.pre.mk>
>> +
>> +do-configure:
>> +       @if [ ! -f ${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm ]; then =
\
>> +               ${ECHO_CMD} ERROR: ImageMagick must be installed with =
the PERL option enabled; \
>> +               ${FALSE}; \
>> +       fi
>>=20
>> pre-install:
>>        @${MKDIR} ${STAGEDIR}${PREFIX}/www/data
>>=20
>> -.include <bsd.port.mk>
>> +.include <bsd.port.post.mk>
>>=20
>=20
> Hi,
>=20
> A custom do-configure looks really wrong..

Oops, fixed, thanks!

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org