From nobody Tue Aug 3 13:43:36 2021 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4FB1512D94ED for ; Tue, 3 Aug 2021 13:43:38 +0000 (UTC) (envelope-from mw@wipp.bayern) Received: from virgo.wipp.bayern (virgo.wipp.bayern [46.4.150.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GfGL20FScz4TnL; Tue, 3 Aug 2021 13:43:37 +0000 (UTC) (envelope-from mw@wipp.bayern) Received: from smtpclient.apple (unknown [IPv6:2a02:8106:209:e43c:313e:37ba:dd1a:3cf0]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: mw@wipp.bayern) by virgo.wipp.bayern (Postfix) with ESMTPSA id ACAC2C664; Tue, 3 Aug 2021 15:43:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wipp.bayern; s=dkim201411; t=1627998217; bh=7JD6sbDXBVtr67tBjoDDlZSZRgrtTE7mn4vgKUnY0fQ=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=djOK4ib7aMTQg9nezFfLwMnyl0QPnqf6ziTpFR4GU3mxCnw/kClaHXWj1R1UTo6Hs TysLhYOhJvDc5mXCXeVXX+Ib+TQTAJlnP7ls3jzonyprpCgP7bTB85DVmL7AA3MifF 5OsYA1uiJ/iAch5tGVa2UnSEIU+upWSX/DcRAapQ= X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.3 at gemini.wipp.bayern From: Markus Wipp Message-Id: <993AB7FE-D206-49E6-B432-3431017D40DD@wipp.bayern> Content-Type: multipart/alternative; boundary="Apple-Mail=_079AEBE3-A4CE-4D3E-B31A-CC4945E41DE7" List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: Issues with security/step-cli Date: Tue, 3 Aug 2021 15:43:36 +0200 In-Reply-To: <20210803153141.61e87955@bsd64.grem.de> Cc: freebsd-ports@freebsd.org, portmgr@freebsd.org To: Michael Gmelin References: <9F64FFEB-6525-49EA-9BDF-C60E64878261@wipp.bayern> <70C8D71B-880A-4D11-83CD-C680E7BF4898@grem.de> <20210803143418.23df9eca@bsd64.grem.de> <04D905BA-565F-41DE-8AE8-44E500F50E89@wipp.bayern> <20210803153141.61e87955@bsd64.grem.de> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4GfGL20FScz4TnL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: Y --Apple-Mail=_079AEBE3-A4CE-4D3E-B31A-CC4945E41DE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 3. Aug 2021, at 15:31, Michael Gmelin wrote: >=20 >=20 >=20 > On Tue, 3 Aug 2021 14:53:07 +0200 > Markus Wipp > wrote: >=20 >>> On 3. Aug 2021, at 14:34, Michael Gmelin wrote: >>>=20 >>>=20 >>>=20 >>> On Tue, 3 Aug 2021 13:41:42 +0200 >>> Markus Wipp wrote: >>>=20 >>>> Sure. I attached you the diff. >>>>=20 >>>>=20 >>>>> On 3. Aug 2021, at 13:35, Michael Gmelin wrote: >>>>>=20 >>>>>=20 >>>>>=20 >>>>>> On 3. Aug 2021, at 13:29, Markus Wipp wrote: >>>>>>=20 >>>>>> =EF=BB=BFHi all,=20 >>>>>>=20 >>>>>> I=E2=80=99m the maintainer of the security/step-cli port and = I=E2=80=99m >>>>>> currently facing some issues, I seem to be unable to fix. >>>>>>=20 >>>>>> I currently try to create the patch for the latest version 0.16.1 >>>>>>=20 >>>>>> I did the following: >>>>>>=20 >>>>>> 1) I removed all files in /usr/ports/distfiles >>>>>> 2) I did a make clean makesum stage (which ran fine) >>>>>> 3) I did a make clean package (which always runs into the >>>>>> following error: =3D> Attempting to fetch >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No such >>>>>> file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory >>>>>> fetch: >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz: >>>>>> size unknown fetch: >>>>>> = https://codeload.github.com/etcd-io/etcd/tar.gz/v3.5.0?dummy=3D/etcd-io-et= cd-v3.5.0_GH0.tar.gz: >>>>>> size of remote file is not known etcd-io-etcd-v3.5.0_GH0.tar.gz >>>>>> 3925 kB 10 MBps 00s =3D> Attempting to >>>>>> fetch >>>>>> = http://distcache.FreeBSD.org/ports-distfiles/etcd-io-etcd-v3.5.0_GH0.tar.g= z >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No such >>>>>> file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No >>>>>> such file or directory fetch: 4020010: No such file or directory >>>>>> fetch: 4020010: No such file or directory fetch: 4020010: No >>>>>> such file or directory fetch: 4020010: No such file or directory >>>>>> fetch: >>>>>> = http://distcache.FreeBSD.org/ports-distfiles/etcd-io-etcd-v3.5.0_GH0.tar.g= z: >>>>>> Not Found =3D> Couldn't fetch it - please try to retrieve this =3D>= >>>>>> port manually into /usr/ports/distfiles/ and try again. *** >>>>>> Error code 1 >>>>>>=20 >>>>>> Is there anything I did wrong? Anything I can do to fix this >>>>>> issue?=20 >>>>>=20 >>>>> Unless someone else knows what=E2=80=99s wrong anyway: Could you = share >>>>> your port skeleton? (at least the files that changed or the >>>>> output of `git diff=E2=80=99) >>>>>=20 >>>>>=20 >>>>>> Thanks in advance >>>>>> Markus =20 >>>>=20 >>>=20 >>> distinfo contains the entry for etcd-io-etcd-v3.5.0_GH0.tar.gz >>> multiple times (due to it being listed multiple times in GH_TUPLE). >>>=20 >>> It seems to build okay when getting rid of the duplicates in >>> distinfo. I don't know if what you're doing is officially >>> supported, but if it is, we should probably adapt tooling. Also, >>> portlint didn't complain and `make makesum' re-creates the >>> duplicates. >>>=20 >>> @portmgr Please find attached an example of a patch that dedups >>> distinfo on `make makesum', it might more sense to fix this >>> somewhere else in the framework (so that e.g., checksums aren't >>> validated multiple times etc.), up to you. =20 >>=20 >> Ok, then this is one more thing I should take care of! I did not add >> it multiple times on purpose. The GH_TUPLE was just built with go mod >> vendor and modules2tuple. Could it be that there the duplicates need >> to be fixed? >=20 > Well, it seems like they are unpacked in multiple places. I don't know > the software well enough if this is required or not. If it is, you > could leave things as they are now and modify distinfo manually (if = this > is actually allowed by the framework). >=20 > It would be nicer though to create a post-extract target that moves > things into place explicitly (either by copying them, or simply by > creating symbolic links, if this is supported by the software you're > porting). Ok, I will for now remove it manually from the distinfo file. I=E2=80=99m not sure whether it is supported and whether it is worth the = effort, but will have a look at it later and try to understand what = you=E2=80=99re suggesting. Thanks for your quick help! Markus >=20 > -m >=20 >>=20 >>=20 >>>=20 >>> Cheers, >>> Michael >>>=20 >>> --=20 >>> Michael Gmelin >>> =20 >=20 >=20 >=20 > --=20 > Michael Gmelin --Apple-Mail=_079AEBE3-A4CE-4D3E-B31A-CC4945E41DE7--