From owner-freebsd-testing@FreeBSD.ORG Sun Mar 22 21:29:47 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 158C1E9C; Sun, 22 Mar 2015 21:29:47 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE03F9C2; Sun, 22 Mar 2015 21:29:46 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::b11b:b36a:c2e8:f12e] (unknown [IPv6:2001:7b8:3a7:0:b11b:b36a:c2e8:f12e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C15E35C4C; Sun, 22 Mar 2015 22:29:44 +0100 (CET) Subject: Re: Jenkins build is still unstable: FreeBSD_HEAD-tests2 #867 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b6 From: Dimitry Andric In-Reply-To: Date: Sun, 22 Mar 2015 22:29:43 +0100 Message-Id: <494AEF4B-0AF8-449A-9B41-9AC4F4552AF0@FreeBSD.org> References: <1669399171.13.1427029129760.JavaMail.jenkins@jenkins-9.freebsd.org> <799490341.14.1427048792932.JavaMail.jenkins@jenkins-9.freebsd.org> To: Craig Rodrigues X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-testing@freebsd.org" , freebsd-current Current , "jenkins-admin@freebsd.org" , freebsd-toolchain@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2015 21:29:47 -0000 --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 22 Mar 2015, at 22:23, Dimitry Andric wrote: >=20 > On 22 Mar 2015, at 22:02, Craig Rodrigues wrote: >>=20 >> On Sun, Mar 22, 2015 at 11:26 AM, wrote: >>=20 >>> See >>>=20 >>=20 >> Can someone with toolchain expertise look at this? >> After the clang 3.6.1 import, /bin/expr behaves differently. >>=20 >> With clang 3.5.0: >>=20 >> # expr 4611686018427387904 + 4611686018427387904 >> expr: overflow >>=20 >> With clang 3.6.1: >>=20 >> # expr 4611686018427387904 + 4611686018427387904 >> -9223372036854775808 >=20 > It works fine for me: >=20 > $ /usr/obj/usr/src/bin/expr/expr 4611686018427387904 + = 4611686018427387904 > expr: overflow Ah right, that was on i386, on amd64 it does result in -2^63. It is = indeed caused by reliance on signed integer wrapping. This diff should fix it, without rewriting the utility: Index: bin/expr/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- bin/expr/Makefile (revision 280156) +++ bin/expr/Makefile (working copy) @@ -6,6 +6,9 @@ PROG=3D expr SRCS=3D expr.y YFLAGS=3D +# expr relies on signed integer wrapping +CFLAGS+=3D -fwrapv + NO_WMISSING_VARIABLE_DECLARATIONS=3D .if ${MK_TESTS} !=3D "no" -Dimitry --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.27 iEYEARECAAYFAlUPNEcACgkQsF6jCi4glqP5HwCeKYgKWHDn47Xr4qJQROpKmJo5 jxYAoO+QWs7JjiiTgzGMaXmRrepUcuHD =pRHL -----END PGP SIGNATURE----- --Apple-Mail=_1B247339-B440-44BF-81CB-2C53DA7C0EB4--