Date: Fri, 8 Nov 2002 14:18:17 +0100 (CET) From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> To: Pierre Beyssac <beyssac@enst.fr> Cc: Pierre Beyssac <pb@fasterix.frmug.org>, Dag-Erling Smorgrav <des@ofug.org>, Krzysztof J?druczyk <beaker@hot.pl>, <freebsd-current@freebsd.org>, Poul-Henning Kamp <phk@freebsd.org>, Alfred Perlstein <bright@mu.org> Subject: Re: Wine-2002.10.07 port on FreeBSD 5.0-current Message-ID: <Pine.BSF.4.44.0211081411050.74479-100000@naos.dbai.tuwien.ac.at> In-Reply-To: <20021108140401.A44559@bofh.enst.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 8 Nov 2002, Pierre Beyssac wrote: > Fine, but if included "as is" in Wine because, it will break > compatibility with Net/OpenBSD because DBREG_DRX is a FreeBSDism... > that's why I surrounded my patch with a #ifdef DBREG_DRX (which > seems cleaner than a #ifdef __FreeBSD__). Sheesh. PHK, now we have the situation where user programs require #ifdefs to be portable among the BSDs when this was not required before. Please consider reverting revision 1.28 date: 2002/10/20 20:48:56; author: phk; state: Exp; lines: +6 -9 Change the definition of the debugging registers to be an array, so that we can index into it, rather than do pointer gymnastics on a structure containing 8 elements. in src/sys/i386/include/reg.h. Gerald PS: Pierre, thanks a lot for spotting and addressing this! I certainly agree with preferring #ifdef DBREG_DRX over #ifdef __FreeBSD__. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.44.0211081411050.74479-100000>