From owner-p4-projects@FreeBSD.ORG Thu Jun 15 18:42:42 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3DF3816A47F; Thu, 15 Jun 2006 18:42:42 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C69216A47D for ; Thu, 15 Jun 2006 18:42:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7EB1643D45 for ; Thu, 15 Jun 2006 18:42:41 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k5FIgZgo049637; Thu, 15 Jun 2006 14:42:40 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Divacky Roman Date: Thu, 15 Jun 2006 14:35:04 -0400 User-Agent: KMail/1.9.1 References: <200606131712.k5DHCIjF063625@repoman.freebsd.org> <200606131344.08736.jhb@freebsd.org> <20060615081925.GB34336@stud.fit.vutbr.cz> In-Reply-To: <20060615081925.GB34336@stud.fit.vutbr.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606151435.04624.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 15 Jun 2006 14:42:40 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1539/Wed Jun 14 10:21:49 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 99144 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2006 18:42:42 -0000 On Thursday 15 June 2006 04:19, Divacky Roman wrote: > On Tue, Jun 13, 2006 at 01:44:08PM -0400, John Baldwin wrote: > > On Tuesday 13 June 2006 13:12, Roman Divacky wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=99144 > > > > > > Change 99144 by rdivacky@rdivacky_witten on 2006/06/13 17:12:02 > > > > > > Make the LINUXBASE path settable via sysctl. Useful when you have more then > > one linux bases > > > installed etc. > > > > Since you only check the one global variable, why did you make the sysctl's > > try to handle per-prison paths? > > well... none of the per-prison variables is checkd against anywhere so I > thought there's some magic behind and just copied the code from the other > variables. > > can you explain me how this works? to me it seems either like unfinished work > or nonsense :) All the other per-prison variables are accessed via the linux_get_foo() functions (like uname, etc.) and those functions look in the prison. However, you are passing linux_emul_path directly to calls to kern_alternate_path() (see the CHECKALT macros). You would have to change those macros to instead call a linux_get_path() function that looked in the prison if you wanted different prisons to have their own compat paths. -- John Baldwin