From owner-freebsd-smp Tue Mar 12 4:20: 5 2002 Delivered-To: freebsd-smp@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id DA3A937B400; Tue, 12 Mar 2002 04:19:55 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA23413; Tue, 12 Mar 2002 23:19:52 +1100 Date: Tue, 12 Mar 2002 23:21:13 +1100 (EST) From: Bruce Evans X-X-Sender: To: John Baldwin Cc: Alfred Perlstein , , Subject: RE: select fix and giant pushdown patch In-Reply-To: Message-ID: <20020312231256.V11516-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, 11 Mar 2002, John Baldwin wrote: > On 11-Mar-02 Alfred Perlstein wrote: > > Index: dev/kbd/kbd.c > > =================================================================== > > RCS file: /home/ncvs/src/sys/dev/kbd/kbd.c,v > > retrieving revision 1.27 > > diff -u -r1.27 kbd.c > > --- dev/kbd/kbd.c 12 Sep 2001 08:37:06 -0000 1.27 > > +++ dev/kbd/kbd.c 10 Mar 2002 08:08:36 -0000 > > @@ -524,7 +524,7 @@ > > #endif > > clist_alloc_cblocks(&sc->gkb_q, KB_QSIZE, KB_QSIZE/2); /* XXX */ > > sc->gkb_rsel.si_flags = 0; > > - sc->gkb_rsel.si_pid = 0; > > + SEL_INIT(&sc->gkb_rsel); > > splx(s); > > > > return 0; > > softc's are already zero'd so you don't need this at all. SEL_INIT() might be magic though. In practice, it only initializes to 0 and NULL, so it is only needed if the memory is already zero'd on machines where NULL is not all zeros. I dislike macros that do trivial initializations anyway. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message