From owner-freebsd-bugs@freebsd.org Mon Oct 8 01:07:18 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8601D10ADFE9 for ; Mon, 8 Oct 2018 01:07:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0D07A732CA for ; Mon, 8 Oct 2018 01:07:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C604810ADFE8; Mon, 8 Oct 2018 01:07:17 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4D2210ADFE7 for ; Mon, 8 Oct 2018 01:07:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 55B5D732BD for ; Mon, 8 Oct 2018 01:07:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8AAD12010F for ; Mon, 8 Oct 2018 01:07:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w9817GFO028861 for ; Mon, 8 Oct 2018 01:07:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w9817Gqt028860 for bugs@FreeBSD.org; Mon, 8 Oct 2018 01:07:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232021] zfs cannot mount 'dataset': Insufficient privileges Date: Mon, 08 Oct 2018 01:07:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: allanjude@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 01:07:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232021 --- Comment #12 from Allan Jude --- After investigating further, I am a bit torn on this one. Rules that apply to mounting: if vfs.usermount =3D=3D 1, user must own the directory they are attempting = to mount to https://svnweb.freebsd.org/base/head/sys/kern/vfs_mount.c?view=3Dmarkup#l855 Rules that apply to unmounting: if vfs.usermount =3D=3D 1, user must be the one who mounted the filesystem UNLESS the filesystem has the VFCF_DELEGADMIN flag (which ZFS does), in whi= ch case the 'who did the mounting' check is bypassed.=20 https://svnweb.freebsd.org/base/head/sys/kern/vfs_subr.c?view=3Dmarkup#l718 So, ZFS has an exception to the vfs.usermount rule for unmounting. The kern= el allows ZFS to implement its own checks (zfs allow mount) to determine if the umount operation should succeed. This feels oddly asymmetrical to me, although I see the additional security considerations for mounting, vs umounting. Making the vfs.usermount 'who did the mounting' check apply feels like a regression against the administrators expressed intent with 'zfs allow moun= t' on the target filesystem. So it may be the case that we just need to document this as the intended behaviour. --=20 You are receiving this mail because: You are the assignee for the bug.=