Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Nov 2020 05:58:56 +0000 (UTC)
From:      Peter Grehan <grehan@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r368047 - head/sys/amd64/vmm/amd
Message-ID:  <202011260558.0AQ5wuYM078970@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: grehan
Date: Thu Nov 26 05:58:55 2020
New Revision: 368047
URL: https://svnweb.freebsd.org/changeset/base/368047

Log:
  Remove manual instruction encodings for	VMLOAD, VMRUN, and VMSAVE.
  
  This is	a relic	from when these	instructions weren't supported by the toolchain.
  No functional change.
  
  Submitted by:	adam_fenn.io
  Reviewed by:	grehan
  Approved by:	grehan (bhyve)
  MFC after:	3 days
  Differential Revision:	https://reviews.freebsd.org/D27130

Modified:
  head/sys/amd64/vmm/amd/svm_support.S

Modified: head/sys/amd64/vmm/amd/svm_support.S
==============================================================================
--- head/sys/amd64/vmm/amd/svm_support.S	Thu Nov 26 04:55:02 2020	(r368046)
+++ head/sys/amd64/vmm/amd/svm_support.S	Thu Nov 26 05:58:55 2020	(r368047)
@@ -39,10 +39,6 @@
 #define	VENTER  push %rbp ; mov %rsp,%rbp
 #define	VLEAVE  pop %rbp
 
-#define	VMLOAD	.byte 0x0f, 0x01, 0xda
-#define	VMRUN	.byte 0x0f, 0x01, 0xd8
-#define	VMSAVE	.byte 0x0f, 0x01, 0xdb
-
 /*
  * svm_launch(uint64_t vmcb, struct svm_regctx *gctx, struct pcpu *pcpu)
  * %rdi: physical address of VMCB
@@ -91,9 +87,9 @@ ENTRY(svm_launch)
 	movq SCTX_RDI(%rsi), %rdi
 	movq SCTX_RSI(%rsi), %rsi	/* %rsi must be restored last */
 
-	VMLOAD
-	VMRUN
-	VMSAVE
+	vmload %rax
+	vmrun %rax
+	vmsave %rax
 
 	pop %rax		/* pop guest context pointer from the stack */
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011260558.0AQ5wuYM078970>