From owner-cvs-all Thu Sep 13 9:46:25 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 3957637B40A; Thu, 13 Sep 2001 09:46:17 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8DGkFi20927; Thu, 13 Sep 2001 17:46:15 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8DGkCd92727; Thu, 13 Sep 2001 17:46:12 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200109131646.f8DGkCd92727@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Ruslan Ermilov Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c In-Reply-To: Message from Ruslan Ermilov of "Thu, 13 Sep 2001 13:06:10 +0300." <20010913130610.B35618@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 13 Sep 2001 17:46:12 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Thu, Sep 13, 2001 at 11:29:08AM +0200, Dag-Erling Smorgrav wrote: > > Ruslan Ermilov writes: > > > With this, the patch looks almost the same as it was in my reply. > > > Modulo the stripping of the terminal dot. > > > > Sorry, but all your patches are incorrect as they do not allow for the > > (perfectly valid) local.host.localdomain.net -> local.host scenario. > > The only thing missing from my second commit was a strcasecmp() call. > > > Right, I did realize that. Your last patch looks OK modulo minor > style bugs (missing spaces surrounding `+' and `-' operators). With my eyes tied behind my head and not looking at the code.... shouldn't we be using trimdomain() and -lutil ? > Cheers, > -- > Ruslan Ermilov Oracle Developer/DBA, > ru@sunbay.com Sunbay Software AG, > ru@FreeBSD.org FreeBSD committer, > +380.652.512.251 Simferopol, Ukraine > > http://www.FreeBSD.org The Power To Serve > http://www.oracle.com Enabling The Information Age -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message